mirror of
https://github.com/Kelsidavis/WoWee.git
synced 2026-04-10 14:53:51 +00:00
97106bd6ae
Magic number elimination: - Create protocol_constants.hpp, warden_constants.hpp, render_constants.hpp, ui_constants.hpp - Replace ~55 magic numbers across game_handler, warden_handler, m2_renderer_render Reduce nesting depth: - Extract 5 parseEffect* methods from handleSpellLogExecute (max indent 52 → 16 cols) - Extract resolveSpellSchool/playSpellCastSound/playSpellImpactSound from 3× duplicate audio blocks in handleSpellGo - Flatten SMSG_INVENTORY_CHANGE_FAILURE with early-return guards - Extract drawScreenEdgeVignette() for 3 duplicate vignette blocks DRY extract patterns: - Replace 12 compound expansion checks with isPreWotlk() across movement_handler (9), chat_handler (1), social_handler (1) const to constexpr: - Promote 23+ static const arrays/scalars to static constexpr across 12 source files Error handling: - Convert PIN auth from exceptions to std::optional<PinProof> - Add [[nodiscard]] to 15+ initialize/parse methods - Wrap ~20 unchecked initialize() calls with LOG_WARNING/LOG_ERROR Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com>
31 lines
936 B
C++
31 lines
936 B
C++
#pragma once
|
|
|
|
#include <array>
|
|
#include <cstdint>
|
|
#include <optional>
|
|
#include <string>
|
|
|
|
namespace wowee {
|
|
namespace auth {
|
|
|
|
struct PinProof {
|
|
std::array<uint8_t, 16> clientSalt{};
|
|
std::array<uint8_t, 20> hash{};
|
|
};
|
|
|
|
// Implements the "PIN" security extension used in the WoW auth protocol (securityFlags & 0x01).
|
|
// Algorithm based on documented client behavior:
|
|
// - Remap digits using pinGridSeed (a permutation of 0..9)
|
|
// - Convert user-entered PIN digits into randomized indices in that permutation
|
|
// - Compute: pin_hash = SHA1(client_salt || SHA1(server_salt || randomized_pin_ascii))
|
|
//
|
|
// PIN must be 4-10 ASCII digits.
|
|
// Returns std::nullopt on invalid input (bad length, non-digit chars, or grid corruption).
|
|
[[nodiscard]] std::optional<PinProof> computePinProof(
|
|
const std::string& pinDigits,
|
|
uint32_t pinGridSeed,
|
|
const std::array<uint8_t, 16>& serverSalt);
|
|
|
|
} // namespace auth
|
|
} // namespace wowee
|
|
|