phaneron/smartcmd-MinecraftConsoles
1
0
Fork 0
mirror of https://github.com/smartcmd/MinecraftConsoles.git synced 2026-05-23 14:13:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Modernize project codebase (#906)

Browse source 
* Fixed boats falling and a TP glitch #266

* Replaced every C-style cast with C++ ones

* Replaced every C-style cast with C++ ones

* Fixed boats falling and a TP glitch #266

* Updated NULL to nullptr and fixing some type issues

* Modernized and fixed a few bugs

- Replaced most instances of `NULL` with `nullptr`.
- Replaced most `shared_ptr(new ...)` with `make_shared`.
- Removed the `nullptr` macro as it was interfering with the actual nullptr keyword in some instances.

* Fixing more conflicts

* Replace int loops with size_t and start work on overrides

* Add safety checks and fix a issue with vector going OOR
This commit is contained in:
ModMaker101 2026-03-08 19:08:36 -04:00 • committed by GitHub
parent 88798b501d
commit 28614b922f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1373 changed files with 20086 additions and 19527 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Minecraft.World/Pos.cpp
View file

@ -28,13 +28,13 @@ Pos::Pos(Pos *position)
bool Pos::equals(void *other)
{
// TODO 4J Stu I cannot do a dynamic_cast from a void pointer
// If I cast it to a Pos then do a dynamic_cast will it still return NULL if it wasn't originally a Pos?
if (!( dynamic_cast<Pos *>( (Pos *)other ) != NULL ))
// If I cast it to a Pos then do a dynamic_cast will it still return nullptr if it wasn't originally a Pos?
if (!( dynamic_cast<Pos *>( static_cast<Pos *>(other) ) != nullptr ))
{
return false;
}
Pos *p = (Pos *) other;
Pos *p = static_cast<Pos *>(other);
return x == p->x && y == p->y && z == p->z;
}