phaneron/smartcmd-MinecraftConsoles
1
0
Fork 0
mirror of https://github.com/smartcmd/MinecraftConsoles.git synced 2026-05-11 19:53:52 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Modernize project codebase (#906)

Browse source 
* Fixed boats falling and a TP glitch #266

* Replaced every C-style cast with C++ ones

* Replaced every C-style cast with C++ ones

* Fixed boats falling and a TP glitch #266

* Updated NULL to nullptr and fixing some type issues

* Modernized and fixed a few bugs

- Replaced most instances of `NULL` with `nullptr`.
- Replaced most `shared_ptr(new ...)` with `make_shared`.
- Removed the `nullptr` macro as it was interfering with the actual nullptr keyword in some instances.

* Fixing more conflicts

* Replace int loops with size_t and start work on overrides

* Add safety checks and fix a issue with vector going OOR
This commit is contained in:
ModMaker101 2026-03-08 19:08:36 -04:00 • committed by GitHub
parent 88798b501d
commit 28614b922f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1373 changed files with 20086 additions and 19527 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Minecraft.World/TargetGoal.cpp
View file

@ -34,7 +34,7 @@ TargetGoal::TargetGoal(PathfinderMob *mob, bool mustSee, bool mustReach)
bool TargetGoal::canContinueToUse()
{
shared_ptr<LivingEntity> target = mob->getTarget();
if (target == NULL) return false;
if (target == nullptr) return false;
if (!target->isAlive()) return false;
double within = getFollowDistance();
@ -56,7 +56,7 @@ bool TargetGoal::canContinueToUse()
double TargetGoal::getFollowDistance()
{
AttributeInstance *followRange = mob->getAttribute(SharedMonsterAttributes::FOLLOW_RANGE);
return followRange == NULL ? 16 : followRange->getValue();
return followRange == nullptr ? 16 : followRange->getValue();
}
void TargetGoal::start()
@ -73,16 +73,16 @@ void TargetGoal::stop()
bool TargetGoal::canAttack(shared_ptr<LivingEntity> target, bool allowInvulnerable)
{
if (target == NULL) return false;
if (target == nullptr) return false;
if (target == mob->shared_from_this()) return false;
if (!target->isAlive()) return false;
if (!mob->canAttackType(target->GetType())) return false;
OwnableEntity *ownableMob = dynamic_cast<OwnableEntity *>(mob);
if (ownableMob != NULL && !ownableMob->getOwnerUUID().empty())
if (ownableMob != nullptr && !ownableMob->getOwnerUUID().empty())
{
shared_ptr<OwnableEntity> ownableTarget = dynamic_pointer_cast<OwnableEntity>(target);
if (ownableTarget != NULL && ownableMob->getOwnerUUID().compare(ownableTarget->getOwnerUUID()) == 0)
if (ownableTarget != nullptr && ownableMob->getOwnerUUID().compare(ownableTarget->getOwnerUUID()) == 0)
{
// We're attacking something owned by the same person...
return false;
@ -117,9 +117,9 @@ bool TargetGoal::canReach(shared_ptr<LivingEntity> target)
{
reachCacheTime = 10 + mob->getRandom()->nextInt(5);
Path *path = mob->getNavigation()->createPath(target);
if (path == NULL) return false;
if (path == nullptr) return false;
Node *last = path->last();
if (last == NULL)
if (last == nullptr)
{
delete path;
return false;