thunderbrewhq/squall
1
0
Fork 0
mirror of https://github.com/thunderbrewhq/squall.git synced 2026-02-04 00:49:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore(hash): ensure correct const declarations in HASHKEY classes

Browse source
This commit is contained in:
fallenoak 2025-09-03 17:18:13 -05:00
parent 73e0097395
commit 195e0319d1
3 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
storm/hash/Hashkey.cpp
View file

@ -14,7 +14,7 @@ HASHKEY_PTR::HASHKEY_PTR(void* key) {
this->m_key = key; this->m_key = key;
} }
bool HASHKEY_PTR::operator==(const HASHKEY_PTR& key) { bool HASHKEY_PTR::operator==(const HASHKEY_PTR& key) const {
return this->m_key == key.m_key; return this->m_key == key.m_key;
} }
@ -44,7 +44,7 @@ HASHKEY_STR& HASHKEY_STR::operator=(const char* str) {
return *this; return *this;
} }
bool HASHKEY_STR::operator==(const char* str) { bool HASHKEY_STR::operator==(const char* str) const {
return SStrCmp(this->m_str, str, STORM_MAX_STR) == 0; return SStrCmp(this->m_str, str, STORM_MAX_STR) == 0;
} }
@ -53,6 +53,6 @@ HASHKEY_STRI& HASHKEY_STRI::operator=(const char* str) {
return *this; return *this;
} }
bool HASHKEY_STRI::operator==(const char* str) { bool HASHKEY_STRI::operator==(const char* str) const {
return SStrCmpI(this->m_str, str, STORM_MAX_STR) == 0; return SStrCmpI(this->m_str, str, STORM_MAX_STR) == 0;
} }

6
storm/hash/Hashkey.hpp
View file

@ -9,7 +9,7 @@ class HASHKEY_PTR {
// Member functions // Member functions
HASHKEY_PTR(); HASHKEY_PTR();
HASHKEY_PTR(void* key); HASHKEY_PTR(void* key);
bool operator==(const HASHKEY_PTR& key); bool operator==(const HASHKEY_PTR& key) const;
}; };
class HASHKEY_STR { class HASHKEY_STR {
@ -22,14 +22,14 @@ class HASHKEY_STR {
HASHKEY_STR(const char* str); HASHKEY_STR(const char* str);
~HASHKEY_STR(); ~HASHKEY_STR();
HASHKEY_STR& operator=(const char* str); HASHKEY_STR& operator=(const char* str);
bool operator==(const char* str); bool operator==(const char* str) const;
}; };
class HASHKEY_STRI : public HASHKEY_STR { class HASHKEY_STRI : public HASHKEY_STR {
public: public:
// Member functions // Member functions
HASHKEY_STRI& operator=(const char* str); HASHKEY_STRI& operator=(const char* str);
bool operator==(const char* str); bool operator==(const char* str) const;
}; };
class HASHKEY_NONE { class HASHKEY_NONE {

6
test/Hash.cpp
View file

@ -18,19 +18,19 @@ TEST_CASE("HASHKEY_PTR", "[hash]") {
SECTION("constructs correctly") { SECTION("constructs correctly") {
HASHKEY_PTR key1; HASHKEY_PTR key1;
HASHKEY_PTR key2; HASHKEY_PTR key2;
REQUIRE(key1.operator==(key2)); REQUIRE(key1 == key2);
void* ptr = reinterpret_cast<void*>(0xDEAFBEEF); void* ptr = reinterpret_cast<void*>(0xDEAFBEEF);
HASHKEY_PTR key3 = { ptr }; HASHKEY_PTR key3 = { ptr };
HASHKEY_PTR key4 = { ptr }; HASHKEY_PTR key4 = { ptr };
REQUIRE(key3.operator==(key4)); REQUIRE(key3 == key4);
} }
} }
TEST_CASE("HASHKEY_STR", "[hash]") { TEST_CASE("HASHKEY_STR", "[hash]") {
SECTION("constructs correctly") { SECTION("constructs correctly") {
HASHKEY_STR key = { "foo" }; HASHKEY_STR key = { "foo" };
REQUIRE(key.operator==("foo")); REQUIRE(key == "foo");
} }
} }