From 6d1d2eefd9c4cdb060fec548c933cc09c889c8df Mon Sep 17 00:00:00 2001 From: fallenoak Date: Tue, 3 Jan 2023 16:58:17 -0600 Subject: [PATCH] chore(array): eliminate sign mismatches --- storm/array/TSFixedArray.hpp | 8 ++++---- storm/array/TSGrowableArray.hpp | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/storm/array/TSFixedArray.hpp b/storm/array/TSFixedArray.hpp index 46a73c5..0a6ca36 100644 --- a/storm/array/TSFixedArray.hpp +++ b/storm/array/TSFixedArray.hpp @@ -15,7 +15,7 @@ class TSFixedArray : public TSBaseArray { template TSFixedArray::~TSFixedArray() { - for (int32_t i = 0; i < this->Count(); i++) { + for (uint32_t i = 0; i < this->Count(); i++) { auto element = &this->operator[](i); element->~T(); } @@ -30,7 +30,7 @@ void TSFixedArray::ReallocData(uint32_t count) { T* oldData = this->m_data; if (count < this->m_count) { - for (int32_t i = count; i < this->m_count; i++) { + for (uint32_t i = count; i < this->m_count; i++) { T* element = &this->m_data[i]; delete element; } @@ -47,7 +47,7 @@ void TSFixedArray::ReallocData(uint32_t count) { if (oldData) { uint32_t smallestCount = count >= this->m_count ? this->m_count : count; - for (int32_t i = 0; i < smallestCount; i++) { + for (uint32_t i = 0; i < smallestCount; i++) { T* v8 = &this->m_data[i]; if (v8) { @@ -66,7 +66,7 @@ void TSFixedArray::SetCount(uint32_t count) { if (count) { this->ReallocData(count); - for (int32_t i = this->m_count; i < count; i++) { + for (uint32_t i = this->m_count; i < count; i++) { new (&this->m_data[i]) T(); } diff --git a/storm/array/TSGrowableArray.hpp b/storm/array/TSGrowableArray.hpp index be2af83..f03c113 100644 --- a/storm/array/TSGrowableArray.hpp +++ b/storm/array/TSGrowableArray.hpp @@ -26,7 +26,7 @@ template uint32_t TSGrowableArray::Add(uint32_t count, const T* data) { this->Reserve(count, 1); - for (int32_t i = 0; i < count; i++) { + for (uint32_t i = 0; i < count; i++) { T* element = &this->m_data[this->m_count + i]; *element = data[i]; } @@ -41,7 +41,7 @@ uint32_t TSGrowableArray::Add(uint32_t count, uint32_t incr, const T* data) { const char* dataptr = reinterpret_cast(data); - for (int32_t i = 0; i < count; i++) { + for (uint32_t i = 0; i < count; i++) { T* element = &this->m_data[this->m_count + i]; *element = *reinterpret_cast(dataptr); dataptr += incr; @@ -129,7 +129,7 @@ void TSGrowableArray::SetCount(uint32_t count) { T* element; - for (int32_t i = this->m_count; i < count; ++i) { + for (uint32_t i = this->m_count; i < count; ++i) { element = &this->m_data[i]; new (element) T(); }