From 0fb3dea2eec5afc7f1c93a1cbf535054f2be2247 Mon Sep 17 00:00:00 2001 From: superp00t Date: Sat, 7 Sep 2024 20:44:57 -0400 Subject: [PATCH] fix(app): resource compilation on MinGW --- src/app/CMakeLists.txt | 6 ++---- src/app/win/Whoa.rc | 8 ++++++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/app/CMakeLists.txt b/src/app/CMakeLists.txt index 5ccf5cc..466df98 100644 --- a/src/app/CMakeLists.txt +++ b/src/app/CMakeLists.txt @@ -3,11 +3,9 @@ if (WHOA_SYSTEM_WIN) add_executable(Whoa WIN32 ${PRIVATE_SOURCES}) + # Set debug icon and description if in debug mode if (CMAKE_BUILD_TYPE STREQUAL "Debug") - target_compile_definitions(Whoa - PRIVATE - -DWHOA_APP_DEBUG - ) + set(CMAKE_RC_FLAGS ${CMAKE_RC_FLAGS} -DWHOA_APP_DEBUG) endif () target_link_libraries(Whoa diff --git a/src/app/win/Whoa.rc b/src/app/win/Whoa.rc index feaf5a9..5f7d14e 100644 --- a/src/app/win/Whoa.rc +++ b/src/app/win/Whoa.rc @@ -1,5 +1,9 @@ #pragma code_page(65001) // UTF-8 +#ifdef _DEBUG +#define WHOA_APP_DEBUG +#endif + #ifdef WHOA_APP_DEBUG BlizzardIcon.ico ICON DISCARDABLE "debug/Whoa.ico" #else @@ -20,7 +24,7 @@ BLOCK "StringFileInfo" BEGIN BLOCK "000004B0" BEGIN -#ifdef _DEBUG +#ifdef WHOA_APP_DEBUG VALUE "FileDescription", L"Whoa (Debug)" #else VALUE "FileDescription", L"Whoa (Release)" @@ -28,7 +32,7 @@ VALUE "FileDescription", L"Whoa (Release)" VALUE "CompanyName", L"Blizzard Entertainment" VALUE "FileVersion", L"3.3.5.12340" VALUE "InternalName", L"World of Warcraft" -VALUE "LegalCopyright", L"Copyright © 2004" +VALUE "LegalCopyright", L"Copyright \xA9 2004" VALUE "LegalTrademarks", L"" VALUE "OriginalFilename", L"Whoa.exe" VALUE "ProductName", L"World of Warcraft"