From 6a06eb16e768c55af5a643410d5124b925cbcc25 Mon Sep 17 00:00:00 2001 From: superp00t Date: Sat, 17 Feb 2024 21:58:52 -0500 Subject: [PATCH] fix(util): SFile::Open() should set to nullptr even in the case of a failure --- src/util/SFile.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/SFile.cpp b/src/util/SFile.cpp index 46ebbb5..f52d68b 100644 --- a/src/util/SFile.cpp +++ b/src/util/SFile.cpp @@ -125,6 +125,7 @@ int32_t SFile::OpenEx(SArchive* archive, const char* filename, uint32_t flags, S // Overflow protection if (SStrLen(filename) + 1 > STORM_MAX_PATH) { + *file = nullptr; return 0; } @@ -146,6 +147,7 @@ int32_t SFile::OpenEx(SArchive* archive, const char* filename, uint32_t flags, S filetype = SFILE_PAQ; filehandle = static_cast(handle); } else { + *file = nullptr; // could not open either plain or MPQ archived file return 0; }