phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3
Kelsidavis-WoWee/include/game/packet_parsers.hpp

473 lines
22 KiB
C++
Raw Normal View History

Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
#pragma once
#include "game/world_packets.hpp"
#include <memory>
#include <string>
namespace wowee {
namespace game {
/**
* PacketParsers - Polymorphic interface for expansion-specific packet parsing.
*
* Binary packet formats differ significantly between WoW expansions
* (movement flags, update fields, character enum layout, etc.).
* Each expansion implements this interface with its specific parsing logic.
*
* The base PacketParsers delegates to the existing static parser classes
* in world_packets.hpp. Expansion subclasses override the methods that
* differ from WotLK.
*/
class PacketParsers {
public:
virtual ~PacketParsers() = default;
Fix Turtle/Classic parsing and online player textures
2026-02-13 19:40:54 -08:00
// Size of MovementInfo.flags2 in bytes for MSG_MOVE_* payloads.
// Classic: none, TBC: u8, WotLK: u16.
virtual uint8_t movementFlags2Size() const { return 2; }
Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
// --- Movement ---
/** Parse movement block from SMSG_UPDATE_OBJECT */
virtual bool parseMovementBlock(network::Packet& packet, UpdateBlock& block) {
return UpdateObjectParser::parseMovementBlock(packet, block);
}
/** Write movement payload for CMSG_MOVE_* packets */
virtual void writeMovementPayload(network::Packet& packet, const MovementInfo& info) {
MovementPacket::writeMovementPayload(packet, info);
}
/** Build a complete movement packet with packed GUID + payload */
virtual network::Packet buildMovementPacket(LogicalOpcode opcode,
const MovementInfo& info,
uint64_t playerGuid = 0) {
return MovementPacket::build(opcode, info, playerGuid);
}
Fix vanilla spell casting and bag contents Vanilla CMSG_CAST_SPELL target mask is uint16 (not uint32 like WotLK), the extra 2 bytes were corrupting packets. Also implement full bag content tracking: extract container slot GUIDs from CONTAINER update objects, set proper bag sizes, and populate bag items in inventory rebuild.
2026-02-13 22:14:34 -08:00
/** Build CMSG_CAST_SPELL (WotLK default: castCount + spellId + castFlags + targets) */
virtual network::Packet buildCastSpell(uint32_t spellId, uint64_t targetGuid, uint8_t castCount) {
return CastSpellPacket::build(spellId, targetGuid, castCount);
}
Fix vanilla spell cast and use-item packet formats for Turtle/Classic SpellCastTargets target mask is uint16 in vanilla 1.12.x, not uint32 like WotLK. The 2 extra bytes corrupted every spell packet. Also add classic CMSG_USE_ITEM builder (bag+slot+spellIndex+targets only, no spellId/itemGuid/glyphIndex/castFlags fields that WotLK added).
2026-02-14 21:29:44 -08:00
/** Build CMSG_USE_ITEM (WotLK default: bag + slot + castCount + spellId + itemGuid + glyphIndex + castFlags + targets) */
Fix item use (CMSG_USE_ITEM), mount tab, and inventory right-click - Fix SMSG_ITEM_QUERY_SINGLE_RESPONSE parsing: read statsCount stat pairs instead of always 10, use 2 damage entries (MAX_ITEM_PROTO_DAMAGES), and parse item spell data (spellId + spellTrigger per slot) - Pass item spell ID in CMSG_USE_ITEM packet so server processes item use requests (spellId=0 caused silent server rejection) - Add spellId parameter to buildUseItem interface across all expansions - Fix spellbook mount tab to use SkillLine 777 (Mounts) instead of 762 (Riding), so known mount summon spells appear correctly - Fix inventory right-click: use IsItemHovered+IsMouseClicked instead of IsItemClicked for InvisibleButton (which only tracks left-clicks) - Fix SlotKind enum declaration order in inventory_screen.hpp
2026-02-26 00:59:07 -08:00
virtual network::Packet buildUseItem(uint8_t bagIndex, uint8_t slotIndex, uint64_t itemGuid, uint32_t spellId = 0) {
return UseItemPacket::build(bagIndex, slotIndex, itemGuid, spellId);
Fix vanilla spell cast and use-item packet formats for Turtle/Classic SpellCastTargets target mask is uint16 in vanilla 1.12.x, not uint32 like WotLK. The 2 extra bytes corrupted every spell packet. Also add classic CMSG_USE_ITEM builder (bag+slot+spellIndex+targets only, no spellId/itemGuid/glyphIndex/castFlags fields that WotLK added).
2026-02-14 21:29:44 -08:00
}
Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
// --- Character Enumeration ---
/** Parse SMSG_CHAR_ENUM */
virtual bool parseCharEnum(network::Packet& packet, CharEnumResponse& response) {
return CharEnumParser::parse(packet, response);
}
// --- Update Object ---
/** Parse a full SMSG_UPDATE_OBJECT packet */
virtual bool parseUpdateObject(network::Packet& packet, UpdateObjectData& data) {
return UpdateObjectParser::parse(packet, data);
}
/** Parse update fields block (value mask + field values) */
virtual bool parseUpdateFields(network::Packet& packet, UpdateBlock& block) {
return UpdateObjectParser::parseUpdateFields(packet, block);
}
// --- Monster Movement ---
/** Parse SMSG_MONSTER_MOVE */
virtual bool parseMonsterMove(network::Packet& packet, MonsterMoveData& data) {
return MonsterMoveParser::parse(packet, data);
}
// --- Combat ---
/** Parse SMSG_ATTACKERSTATEUPDATE */
virtual bool parseAttackerStateUpdate(network::Packet& packet, AttackerStateUpdateData& data) {
return AttackerStateUpdateParser::parse(packet, data);
}
/** Parse SMSG_SPELLNONMELEEDAMAGELOG */
virtual bool parseSpellDamageLog(network::Packet& packet, SpellDamageLogData& data) {
return SpellDamageLogParser::parse(packet, data);
}
tbc: fix heal log GUID parsing and route combat through virtual dispatch Add TbcPacketParsers::parseSpellHealLog override using full uint64 GUIDs (TBC) instead of packed GUIDs (WotLK). Route handleAttackerStateUpdate, handleSpellDamageLog, and handleSpellHealLog through the virtual packetParsers_ interface so expansion-specific overrides are actually called. Previously the game handler bypassed virtual dispatch with direct static parser calls, making all three TBC overrides dead code.
2026-03-09 21:36:12 -07:00
/** Parse SMSG_SPELLHEALLOG */
virtual bool parseSpellHealLog(network::Packet& packet, SpellHealLogData& data) {
return SpellHealLogParser::parse(packet, data);
}
Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
// --- Spells ---
/** Parse SMSG_INITIAL_SPELLS */
virtual bool parseInitialSpells(network::Packet& packet, InitialSpellsData& data) {
return InitialSpellsParser::parse(packet, data);
}
tbc: fix SMSG_SPELL_START and SMSG_SPELL_GO for TBC 2.4.3 TBC 2.4.3 SMSG_SPELL_START and SMSG_SPELL_GO send full uint64 GUIDs for casterGuid/casterUnit and hit targets. WotLK uses packed (variable-length) GUIDs. Using readPackedGuid() on a full uint64 reads the first byte as the bitmask, consuming 1-8 wrong bytes, which shifts all subsequent fields (spellId, castFlags, castTime) and causes: - Cast bar to never show for the player's own spells - Sound effects to use the wrong spell ID - Hit/miss target tracking to be completely wrong Additionally, TBC SMSG_SPELL_GO lacks the WotLK timestamp field after castFlags. Add TbcPacketParsers::parseSpellStart and ::parseSpellGo using full GUIDs, add virtual base methods, and route both handlers through virtual dispatch.
2026-03-09 21:48:41 -07:00
/** Parse SMSG_SPELL_START */
virtual bool parseSpellStart(network::Packet& packet, SpellStartData& data) {
return SpellStartParser::parse(packet, data);
}
/** Parse SMSG_SPELL_GO */
virtual bool parseSpellGo(network::Packet& packet, SpellGoData& data) {
return SpellGoParser::parse(packet, data);
}
Fix Classic/Turtle spell casting, cast fail parsing, and empty chat Three Classic packet format fixes: 1. CMSG_CAST_SPELL: target flags are uint32 (not uint16). The wrong size caused the server to misparse the packet as an item enchant operation, returning "item already enchanted". 2. SMSG_CAST_FAILED: Classic has no castCount byte prefix (added in TBC). Added parseCastFailed override to ClassicPacketParsers. Without this, the parser read the wrong bytes and produced "Spell cast failed (error 0)" for every failure. 3. SMSG_MESSAGECHAT: Removed spurious receiverGuid read for SAY/YELL types. Classic chat format has no second GUID before the message body — the extra 8-byte read consumed messageLen + message data, producing empty chat messages.
2026-02-14 16:54:43 -08:00
/** Parse SMSG_CAST_FAILED */
virtual bool parseCastFailed(network::Packet& packet, CastFailedData& data) {
return CastFailedParser::parse(packet, data);
}
tbc: fix SMSG_CAST_RESULT — no castCount prefix in TBC 2.4.3 TBC 2.4.3 SMSG_CAST_RESULT sends spellId(u32) + result(u8) = 5 bytes. WotLK 3.3.5a added a castCount(u8) prefix making it 6 bytes. Without this fix the WotLK parser was reading spellId[0] as castCount, then the remaining 3 spellId bytes plus result byte as spellId (wrong), and then whatever follows as result — producing incorrect failure messages and potentially not clearing the cast bar on TBC. Add TbcPacketParsers::parseCastResult override and a virtual base method, then route SMSG_CAST_RESULT through virtual dispatch in the game handler.
2026-03-09 21:46:18 -07:00
/** Parse SMSG_CAST_RESULT header (spellId + result), expansion-aware.
* WotLK: castCount(u8) + spellId(u32) + result(u8)
* TBC/Classic: spellId(u32) + result(u8) (no castCount prefix)
*/
virtual bool parseCastResult(network::Packet& packet, uint32_t& spellId, uint8_t& result) {
// WotLK default: skip castCount, read spellId + result
if (packet.getSize() - packet.getReadPos() < 6) return false;
packet.readUInt8(); // castCount
spellId = packet.readUInt32();
result = packet.readUInt8();
return true;
}
Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
/** Parse SMSG_AURA_UPDATE / SMSG_AURA_UPDATE_ALL */
virtual bool parseAuraUpdate(network::Packet& packet, AuraUpdateData& data, bool isAll = false) {
return AuraUpdateParser::parse(packet, data, isAll);
}
Vanilla/Turtle WoW compatibility: fix UPDATE_OBJECT, chat, equipment, creatures - Route SMSG_UPDATE_OBJECT through polymorphic parsers for correct vanilla format (uint8 updateFlags, 6 speeds vs WotLK uint16/9) - Fix SMSG_DESTROY_OBJECT for vanilla (8 bytes, no isDeath field) - Add MSG_MOVE_* handlers for other player movement relay - Add ClassicPacketParsers::parseMessageChat with targetGuid read and monster-type name handling - Resolve chat sender names from player name cache before display - Fix CSV DBC field 0 always treated as numeric ID (fixes 16+ garbled Turtle CSVs including Map, AreaTable, Spell, CreatureDisplayInfo) - Add CSV DBC validation: reject garbled CSVs (>80% zero IDs) and fall back to binary DBC files - Fix ItemDisplayInfo texture component field index (14+ not 15+) for binary DBC with gender-aware suffix resolution - Spawn other players as visible M2 models via creature callback - Map name cache dedup prevents overwrites from duplicate CSV records
2026-02-13 18:59:09 -08:00
// --- Chat ---
/** Parse SMSG_MESSAGECHAT */
virtual bool parseMessageChat(network::Packet& packet, MessageChatData& data) {
return MessageChatParser::parse(packet, data);
}
Fix name query parsing for Classic/TBC
2026-02-13 19:52:49 -08:00
/** Parse SMSG_NAME_QUERY_RESPONSE */
virtual bool parseNameQueryResponse(network::Packet& packet, NameQueryResponseData& data) {
return NameQueryResponseParser::parse(packet, data);
}
classic: fix SMSG_CREATURE_QUERY_RESPONSE — no iconName field in 1.12 Classic 1.12 SMSG_CREATURE_QUERY_RESPONSE has no iconName CString between subName and typeFlags. The TBC/WotLK parser was reading the typeFlags uint32 bytes as the iconName string, then reading the remaining bytes as typeFlags — producing garbage creature type/family/rank values and corrupting target frame display for all creatures on Classic servers. Add ClassicPacketParsers::parseCreatureQueryResponse without the iconName read, and route the game handler through virtual dispatch so the override is called.
2026-03-09 21:44:07 -07:00
// --- Creature Query ---
/** Parse SMSG_CREATURE_QUERY_RESPONSE */
virtual bool parseCreatureQueryResponse(network::Packet& packet, CreatureQueryResponseData& data) {
return CreatureQueryResponseParser::parse(packet, data);
}
Fix NPC textures, bag item interactions, and Classic item query parsing Rebuild creature display lookups after expansion-specific DBC layout loads (was using WotLK defaults before turtle layout was available). Add full drag-and-drop support for bag items with server-side CMSG_SWAP_ITEM packets. Add Classic-specific SMSG_ITEM_QUERY_SINGLE_RESPONSE parser for Vanilla format differences (fewer damage types, no scaling stats, no Flags2).
2026-02-17 01:00:04 -08:00
// --- Item Query ---
Fix Classic item query packet format for auction house item names Vanilla CMSG_ITEM_QUERY_SINGLE has no GUID field (just uint32 entry), causing servers to reject the oversized WotLK-format packets. Also fix response parser: remove nonexistent statsCount field and use 5 damage types instead of 2 to match Vanilla protocol.
2026-02-17 01:05:15 -08:00
/** Build CMSG_ITEM_QUERY_SINGLE */
virtual network::Packet buildItemQuery(uint32_t entry, uint64_t guid) {
return ItemQueryPacket::build(entry, guid);
}
Fix NPC textures, bag item interactions, and Classic item query parsing Rebuild creature display lookups after expansion-specific DBC layout loads (was using WotLK defaults before turtle layout was available). Add full drag-and-drop support for bag items with server-side CMSG_SWAP_ITEM packets. Add Classic-specific SMSG_ITEM_QUERY_SINGLE_RESPONSE parser for Vanilla format differences (fewer damage types, no scaling stats, no Flags2).
2026-02-17 01:00:04 -08:00
/** Parse SMSG_ITEM_QUERY_SINGLE_RESPONSE */
virtual bool parseItemQueryResponse(network::Packet& packet, ItemQueryResponseData& data) {
return ItemQueryResponseParser::parse(packet, data);
}
Add MCLQ water, TaxiPathNode transports, and vanilla M2 particles - Parse MCLQ sub-chunks in vanilla ADTs for water rendering (WotLK uses MH2O) - Load TaxiPathNode.dbc for MO_TRANSPORT world-coordinate paths (vanilla boats) - Parse data[] from SMSG_GAMEOBJECT_QUERY_RESPONSE (taxiPathId for transports) - Support vanilla M2 particle emitters (504-byte struct, different from WotLK 476) - Add character preview texture diagnostic logging - Fix disconnect handling on character screen (show error only when no chars)
2026-02-14 20:20:43 -08:00
// --- GameObject Query ---
/** Parse SMSG_GAMEOBJECT_QUERY_RESPONSE */
virtual bool parseGameObjectQueryResponse(network::Packet& packet, GameObjectQueryResponseData& data) {
return GameObjectQueryResponseParser::parse(packet, data);
}
Fix gossip message parsing for Vanilla/Turtle (flight master hang) Classic gossip packets lack the menuId field and quest items don't have questFlags/isRepeatable, causing the WotLK parser to read garbage counts (541M quests) and hang. Added ClassicPacketParsers::parseGossipMessage override with the correct vanilla format.
2026-02-14 19:38:11 -08:00
// --- Gossip ---
/** Parse SMSG_GOSSIP_MESSAGE */
virtual bool parseGossipMessage(network::Packet& packet, GossipMessageData& data) {
return GossipMessageParser::parse(packet, data);
}
Fix quest system for Classic/Turtle: correct packet formats and log stride - CMSG_QUESTGIVER_QUERY_QUEST: Classic override omits trailing unk1 byte (WotLK sends 13 bytes, Classic servers expect 12 — extra byte caused server to silently drop the packet, preventing quest details dialog) - SMSG_QUESTGIVER_QUEST_DETAILS: Classic override skips informUnit GUID (WotLK prepends 8-byte informUnit before questId; Vanilla does not) - Quest log UPDATE_OBJECT stride: use packetParsers_->questLogStride() (WotLK=5 fields/slot, Classic=3 fields/slot) - handleQuestDetails: route through packetParsers_->parseQuestDetails() - selectGossipQuest: route through packetParsers_->buildQueryQuestPacket()
2026-02-18 04:56:23 -08:00
// --- Quest details ---
/** Build CMSG_QUESTGIVER_QUERY_QUEST.
* WotLK appends a trailing unk1 byte; Vanilla/Classic do not. */
virtual network::Packet buildQueryQuestPacket(uint64_t npcGuid, uint32_t questId) {
return QuestgiverQueryQuestPacket::build(npcGuid, questId); // includes unk1
}
Fix quest accept/abandon flow and expansion-specific accept packet format Normalize WoW quest text tokens during parsing so quest titles/details no longer leak raw markup like and |n into UI. Apply to WotLK and Classic parser paths, including quest list parsing in GameHandler. Harden quest state handling by mapping abandon requests to authoritative server quest-log slots (PLAYER_QUEST_LOG_START) instead of local vector order, with a guarded fallback when update fields are unavailable. Improve accept de-duplication by trusting server slot state over stale local cache; allow re-accept when local/server state diverges and trigger resync semantics. Add expansion-aware CMSG_QUESTGIVER_ACCEPT_QUEST builders: WotLK sends guid+questId+unk1(uint32), while TBC/Classic/Turtle send guid+questId only. Wire GameHandler through PacketParsers for compatibility across expansions and cores.
2026-02-20 23:20:02 -08:00
/** Build CMSG_QUESTGIVER_ACCEPT_QUEST.
* WotLK/AzerothCore expects trailing unk1 uint32; older expansions may not. */
virtual network::Packet buildAcceptQuestPacket(uint64_t npcGuid, uint32_t questId) {
return QuestgiverAcceptQuestPacket::build(npcGuid, questId);
}
Fix quest system for Classic/Turtle: correct packet formats and log stride - CMSG_QUESTGIVER_QUERY_QUEST: Classic override omits trailing unk1 byte (WotLK sends 13 bytes, Classic servers expect 12 — extra byte caused server to silently drop the packet, preventing quest details dialog) - SMSG_QUESTGIVER_QUEST_DETAILS: Classic override skips informUnit GUID (WotLK prepends 8-byte informUnit before questId; Vanilla does not) - Quest log UPDATE_OBJECT stride: use packetParsers_->questLogStride() (WotLK=5 fields/slot, Classic=3 fields/slot) - handleQuestDetails: route through packetParsers_->parseQuestDetails() - selectGossipQuest: route through packetParsers_->buildQueryQuestPacket()
2026-02-18 04:56:23 -08:00
/** Parse SMSG_QUESTGIVER_QUEST_DETAILS.
* WotLK has an extra informUnit GUID before questId; Vanilla/Classic do not. */
virtual bool parseQuestDetails(network::Packet& packet, QuestDetailsData& data) {
return QuestDetailsParser::parse(packet, data); // WotLK auto-detect
}
/** Stride of PLAYER_QUEST_LOG fields in update-object blocks.
* WotLK: 5 fields per slot, Classic/Vanilla: 3. */
virtual uint8_t questLogStride() const { return 5; }
fix: use expansion-aware explored zone count to prevent fog-of-war corruption Classic 1.12 and Turtle WoW have only 64 PLAYER_EXPLORED_ZONES uint32 fields (zone IDs pack into 2048 bits). TBC and WotLK use 128 (needed for Outland/Northrend zone IDs up to bit 4095). The hardcoded PLAYER_EXPLORED_ZONES_COUNT=128 caused extractExploredZoneFields to read 64 extra fields beyond the actual zone block in Classic/Turtle — consuming PLAYER_REST_STATE_EXPERIENCE, PLAYER_FIELD_COINAGE, and character- points fields as zone flags. On the world map, this could mark zones as explored based on random bit patterns in those unrelated fields. Add `exploredZonesCount()` virtual method to PacketParsers (default=128, Classic/Turtle override=64) and use it in extractExploredZoneFields to limit reads to the correct block and zero-fill remaining slots.
2026-03-10 23:18:16 -07:00
/** Number of PLAYER_EXPLORED_ZONES uint32 fields in update-object blocks.
* Classic/Vanilla/Turtle: 64 (bit-packs up to zone ID 2047).
* TBC/WotLK: 128 (covers Outland/Northrend zone IDs up to 4095). */
virtual uint8_t exploredZonesCount() const { return 128; }
Fix Turtle WoW compatibility: NPC spawning, quests, spells, realm display, and music - Add TurtlePacketParsers with dedicated movement block parser (Classic format + transport timestamp) - Fix quest giver status: read uint32 and translate vanilla enum values for Classic/Turtle - Fix quest accept packet: remove trailing uint32 that vanilla servers reject - Fix quest details parser: auto-detect vanilla vs WotLK format (informUnit field) - Fix spellbook and action bar icons: fallback to WotLK DBC field indices when expansion layout fails - Fix spell cast failure messages: translate vanilla SpellCastResult codes (+1 offset) - Fix realm list: correct type values (6=RP, 8=RP-PvP) and population thresholds - Fix music: disable looping for zone music, auto-advance to next random track when finished - Add music anti-repeat: avoid playing the same track back-to-back - Make TBC update block parsing resilient (keep parsed blocks on failure instead of aborting) - Add right-click attack on hostile mobs - Add name query diagnostic logging
2026-02-17 05:27:03 -08:00
// --- Quest Giver Status ---
/** Read quest giver status from packet.
* WotLK: uint8, vanilla/classic: uint32 with different enum values.
* Returns the status value normalized to WotLK enum values. */
virtual uint8_t readQuestGiverStatus(network::Packet& packet) {
return packet.readUInt8();
}
Vanilla/Turtle WoW compatibility: fix UPDATE_OBJECT, chat, equipment, creatures - Route SMSG_UPDATE_OBJECT through polymorphic parsers for correct vanilla format (uint8 updateFlags, 6 speeds vs WotLK uint16/9) - Fix SMSG_DESTROY_OBJECT for vanilla (8 bytes, no isDeath field) - Add MSG_MOVE_* handlers for other player movement relay - Add ClassicPacketParsers::parseMessageChat with targetGuid read and monster-type name handling - Resolve chat sender names from player name cache before display - Fix CSV DBC field 0 always treated as numeric ID (fixes 16+ garbled Turtle CSVs including Map, AreaTable, Spell, CreatureDisplayInfo) - Add CSV DBC validation: reject garbled CSVs (>80% zero IDs) and fall back to binary DBC files - Fix ItemDisplayInfo texture component field index (14+ not 15+) for binary DBC with gender-aware suffix resolution - Spawn other players as visible M2 models via creature callback - Map name cache dedup prevents overwrites from duplicate CSV records
2026-02-13 18:59:09 -08:00
// --- Destroy Object ---
/** Parse SMSG_DESTROY_OBJECT */
virtual bool parseDestroyObject(network::Packet& packet, DestroyObjectData& data) {
return DestroyObjectParser::parse(packet, data);
}
Fix vanilla M2 animations, movement packets, and DBC locale - Parse vanilla M2 animation tracks (flat arrays with M2Range indices) instead of skipping them, fixing T-pose on all vanilla models - Use C4Quaternion (float[4]) for vanilla bone rotations instead of CompressedQuat (int16[4]) which produced garbage transforms - Fix vanilla M2 attachment struct size (48 bytes, not 40) so weapons attach to correct bones instead of model origin - Route movement packets through expansion-specific packet parsers instead of hardcoded WotLK format, fixing server-side position sync - Fix Spell.dbc field indices for classic/turtle (Name=120, Rank=129, IconID=117) - were pointing to Portuguese locale column (+7 offset) - Change guild roster keybind from J to O (WoW default) - Add guild opcodes for all expansions
2026-02-13 21:39:48 -08:00
// --- Guild ---
/** Parse SMSG_GUILD_ROSTER */
virtual bool parseGuildRoster(network::Packet& packet, GuildRosterData& data) {
return GuildRosterParser::parse(packet, data);
}
/** Parse SMSG_GUILD_QUERY_RESPONSE */
virtual bool parseGuildQueryResponse(network::Packet& packet, GuildQueryResponseData& data) {
return GuildQueryResponseParser::parse(packet, data);
}
Add chat channels, chat settings, and fix missing chat text Fix WotLK chat parser not stripping null terminators from messages, fix channel message local echo missing channelName, expand default channels to General/Trade/LocalDefense/LookingForGroup with configurable auto-join, add Classic packet format for join/leave channel, display channel index prefix in chat, and add Chat settings tab with timestamps, font size, and auto-join toggles.
2026-02-14 18:27:59 -08:00
// --- Channels ---
/** Build CMSG_JOIN_CHANNEL */
virtual network::Packet buildJoinChannel(const std::string& channelName, const std::string& password) {
return JoinChannelPacket::build(channelName, password);
}
/** Build CMSG_LEAVE_CHANNEL */
virtual network::Packet buildLeaveChannel(const std::string& channelName) {
return LeaveChannelPacket::build(channelName);
}
Implement mailbox interaction and expansion-aware mail system Fix mailbox right-click (transposed CMSG_GAMEOBJECT_USE opcode, missing mail opcodes in Turtle WoW JSON, decorative GO type filtering). Add expansion-aware mail packet handling via PacketParsers: Classic format (single item, no msgSize prefix, Vanilla field order) vs WotLK format (attachment arrays, enchant slots). Fix CMSG_MAIL_TAKE_ITEM and CMSG_MAIL_DELETE for Vanilla (no trailing fields). Add pulsing "New Mail" indicator below minimap, SMSG_RECEIVED_MAIL and MSG_QUERY_NEXT_MAIL_TIME handlers, and async sender name backfill.
2026-02-16 18:46:44 -08:00
// --- Mail ---
/** Build CMSG_SEND_MAIL */
virtual network::Packet buildSendMail(uint64_t mailboxGuid, const std::string& recipient,
const std::string& subject, const std::string& body,
Add mail item attachment support for sending - CMSG_SEND_MAIL now includes item GUIDs (up to 12 per WotLK) - Right-click items in bags to attach when mail compose is open - Compose window shows 12-slot attachment grid with item icons - Click attached items to remove them - Classic/Vanilla falls back to single item GUID format
2026-02-25 14:11:09 -08:00
uint32_t money, uint32_t cod,
const std::vector<uint64_t>& itemGuids = {}) {
return SendMailPacket::build(mailboxGuid, recipient, subject, body, money, cod, itemGuids);
Implement mailbox interaction and expansion-aware mail system Fix mailbox right-click (transposed CMSG_GAMEOBJECT_USE opcode, missing mail opcodes in Turtle WoW JSON, decorative GO type filtering). Add expansion-aware mail packet handling via PacketParsers: Classic format (single item, no msgSize prefix, Vanilla field order) vs WotLK format (attachment arrays, enchant slots). Fix CMSG_MAIL_TAKE_ITEM and CMSG_MAIL_DELETE for Vanilla (no trailing fields). Add pulsing "New Mail" indicator below minimap, SMSG_RECEIVED_MAIL and MSG_QUERY_NEXT_MAIL_TIME handlers, and async sender name backfill.
2026-02-16 18:46:44 -08:00
}
/** Parse SMSG_MAIL_LIST_RESULT into a vector of MailMessage */
virtual bool parseMailList(network::Packet& packet, std::vector<MailMessage>& inbox);
/** Build CMSG_MAIL_TAKE_ITEM */
fix(mail): use attachment item guid for WotLK take item
2026-03-14 07:11:18 -07:00
virtual network::Packet buildMailTakeItem(uint64_t mailboxGuid, uint32_t mailId, uint32_t itemGuidLow) {
return MailTakeItemPacket::build(mailboxGuid, mailId, itemGuidLow);
Implement mailbox interaction and expansion-aware mail system Fix mailbox right-click (transposed CMSG_GAMEOBJECT_USE opcode, missing mail opcodes in Turtle WoW JSON, decorative GO type filtering). Add expansion-aware mail packet handling via PacketParsers: Classic format (single item, no msgSize prefix, Vanilla field order) vs WotLK format (attachment arrays, enchant slots). Fix CMSG_MAIL_TAKE_ITEM and CMSG_MAIL_DELETE for Vanilla (no trailing fields). Add pulsing "New Mail" indicator below minimap, SMSG_RECEIVED_MAIL and MSG_QUERY_NEXT_MAIL_TIME handlers, and async sender name backfill.
2026-02-16 18:46:44 -08:00
}
/** Build CMSG_MAIL_DELETE */
virtual network::Packet buildMailDelete(uint64_t mailboxGuid, uint32_t mailId, uint32_t mailTemplateId) {
return MailDeletePacket::build(mailboxGuid, mailId, mailTemplateId);
}
Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
// --- Utility ---
/** Read a packed GUID from the packet */
virtual uint64_t readPackedGuid(network::Packet& packet) {
return UpdateObjectParser::readPackedGuid(packet);
}
/** Write a packed GUID to the packet */
virtual void writePackedGuid(network::Packet& packet, uint64_t guid) {
MovementPacket::writePackedGuid(packet, guid);
}
};
/**
* WotLK 3.3.5a packet parsers.
*
* Uses the default implementations which delegate to the existing
* static parser classes. All current parsing code is WotLK-specific,
* so no overrides are needed.
*/
class WotlkPacketParsers : public PacketParsers {
// All methods use the defaults from PacketParsers base class,
// which delegate to the existing WotLK static parsers.
};
/**
* TBC 2.4.3 packet parsers.
*
* Overrides methods where TBC binary format differs from WotLK:
* - SMSG_UPDATE_OBJECT: u8 has_transport after blockCount (WotLK removed it)
* - UpdateFlags is u8 (not u16), no VEHICLE/ROTATION/POSITION flags
* - Movement flags2 is u8 (not u16), no transport seat byte
* - Movement flags: JUMPING=0x2000 gates jump data (WotLK: FALLING=0x1000)
* - SPLINE_ENABLED=0x08000000, SPLINE_ELEVATION=0x04000000 (same as WotLK)
* - Pitch: SWIMMING or else ONTRANSPORT(0x02000000)
* - CharEnum: uint8 firstLogin (not uint32+uint8), 20 equipment items (not 23)
* - Aura updates use inline update fields, not SMSG_AURA_UPDATE
*/
class TbcPacketParsers : public PacketParsers {
public:
Fix Turtle/Classic parsing and online player textures
2026-02-13 19:40:54 -08:00
uint8_t movementFlags2Size() const override { return 1; }
Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
bool parseMovementBlock(network::Packet& packet, UpdateBlock& block) override;
void writeMovementPayload(network::Packet& packet, const MovementInfo& info) override;
network::Packet buildMovementPacket(LogicalOpcode opcode,
const MovementInfo& info,
uint64_t playerGuid = 0) override;
bool parseUpdateObject(network::Packet& packet, UpdateObjectData& data) override;
bool parseCharEnum(network::Packet& packet, CharEnumResponse& response) override;
bool parseAuraUpdate(network::Packet& packet, AuraUpdateData& data, bool isAll = false) override;
Fix name query parsing for Classic/TBC
2026-02-13 19:52:49 -08:00
bool parseNameQueryResponse(network::Packet& packet, NameQueryResponseData& data) override;
Fix TBC item query parser: add TBC-specific parseItemQueryResponse override TBC 2.4.3 SMSG_ITEM_QUERY_SINGLE_RESPONSE differs from WotLK: no Flags2, no BuyCount, statsCount-many stat pairs (not always 10), and no ScalingStatDistribution/ScalingStatValue. Without this override, TbcPacketParsers fell back to the WotLK parser and misread stats/armor with a cascading 16-byte offset. Classic (Vanilla) was already safe via its own independent ClassicPacketParsers::parseItemQueryResponse().
2026-02-19 16:58:18 -08:00
bool parseItemQueryResponse(network::Packet& packet, ItemQueryResponseData& data) override;
Fix quest accept/abandon flow and expansion-specific accept packet format Normalize WoW quest text tokens during parsing so quest titles/details no longer leak raw markup like and |n into UI. Apply to WotLK and Classic parser paths, including quest list parsing in GameHandler. Harden quest state handling by mapping abandon requests to authoritative server quest-log slots (PLAYER_QUEST_LOG_START) instead of local vector order, with a guarded fallback when update fields are unavailable. Improve accept de-duplication by trusting server slot state over stale local cache; allow re-accept when local/server state diverges and trigger resync semantics. Add expansion-aware CMSG_QUESTGIVER_ACCEPT_QUEST builders: WotLK sends guid+questId+unk1(uint32), while TBC/Classic/Turtle send guid+questId only. Wire GameHandler through PacketParsers for compatibility across expansions and cores.
2026-02-20 23:20:02 -08:00
network::Packet buildAcceptQuestPacket(uint64_t npcGuid, uint32_t questId) override;
tbc: fix spell cast format and NPC movement parsing for TBC 2.4.3 CMSG_CAST_SPELL: WotLK adds a castFlags(u8) byte after spellId that TBC 2.4.3 does not have. Add TbcPacketParsers::buildCastSpell() to omit it, preventing every spell cast from being rejected by TBC servers. CMSG_USE_ITEM: WotLK adds a glyphIndex(u32) field between itemGuid and castFlags that TBC 2.4.3 does not have. Add buildUseItem() override. SMSG_MONSTER_MOVE: WotLK adds a uint8 unk byte after the packed GUID (MOVEMENTFLAG2_UNK7 toggle) that TBC 2.4.3 does not have. Add parseMonsterMove() override to fix NPC movement parsing — without this, all NPC positions, durations, and waypoints parse from the wrong byte offset, making all NPC movement appear broken on TBC servers.
2026-03-09 21:14:06 -07:00
// TBC 2.4.3 CMSG_CAST_SPELL has no castFlags byte (WotLK added it)
network::Packet buildCastSpell(uint32_t spellId, uint64_t targetGuid, uint8_t castCount) override;
// TBC 2.4.3 CMSG_USE_ITEM has no glyphIndex field (WotLK added it)
network::Packet buildUseItem(uint8_t bagIndex, uint8_t slotIndex, uint64_t itemGuid, uint32_t spellId = 0) override;
// TBC 2.4.3 SMSG_MONSTER_MOVE has no unk byte after packed GUID (WotLK added it)
bool parseMonsterMove(network::Packet& packet, MonsterMoveData& data) override;
tbc: fix gossip message quest parsing for TBC 2.4.3 SMSG_GOSSIP_MESSAGE quest entries in TBC 2.4.3 do not include questFlags(u32) or isRepeatable(u8) that WotLK 3.3.5a added. The WotLK default parser reads these 5 bytes, causing all quest titles in gossip dialogs to be shifted/corrupted on TBC servers. Add TbcPacketParsers::parseGossipMessage() which parses quest entries without those fields, fixing NPC quest list display.
2026-03-09 21:20:37 -07:00
// TBC 2.4.3 SMSG_GOSSIP_MESSAGE quests lack questFlags(u32)+isRepeatable(u8) (WotLK added them)
bool parseGossipMessage(network::Packet& packet, GossipMessageData& data) override;
tbc: fix SMSG_CAST_RESULT — no castCount prefix in TBC 2.4.3 TBC 2.4.3 SMSG_CAST_RESULT sends spellId(u32) + result(u8) = 5 bytes. WotLK 3.3.5a added a castCount(u8) prefix making it 6 bytes. Without this fix the WotLK parser was reading spellId[0] as castCount, then the remaining 3 spellId bytes plus result byte as spellId (wrong), and then whatever follows as result — producing incorrect failure messages and potentially not clearing the cast bar on TBC. Add TbcPacketParsers::parseCastResult override and a virtual base method, then route SMSG_CAST_RESULT through virtual dispatch in the game handler.
2026-03-09 21:46:18 -07:00
// TBC 2.4.3 SMSG_CAST_RESULT: spellId(u32) + result(u8) — WotLK added castCount(u8) prefix
bool parseCastResult(network::Packet& packet, uint32_t& spellId, uint8_t& result) override;
game: fix TBC 2.4.3 SMSG_CAST_FAILED missing parseCastFailed override TBC 2.4.3 SMSG_CAST_FAILED format is spellId(u32) + result(u8), same as Classic. WotLK added a castCount(u8) prefix before spellId. TbcPacketParsers lacked a parseCastFailed override, so it fell through to the WotLK base which read one extra byte as castCount, shifting the spellId read by one byte and corrupting the spell ID and result for every failed cast on TBC. - Add TbcPacketParsers::parseCastFailed override: reads spellId(4)+result(1) - ClassicPacketParsers already overrides this (enum shift +1), so Classic unaffected
2026-03-10 01:30:06 -07:00
// TBC 2.4.3 SMSG_CAST_FAILED: spellId(u32) + result(u8) — WotLK added castCount(u8) prefix
bool parseCastFailed(network::Packet& packet, CastFailedData& data) override;
tbc: fix SMSG_SPELL_START and SMSG_SPELL_GO for TBC 2.4.3 TBC 2.4.3 SMSG_SPELL_START and SMSG_SPELL_GO send full uint64 GUIDs for casterGuid/casterUnit and hit targets. WotLK uses packed (variable-length) GUIDs. Using readPackedGuid() on a full uint64 reads the first byte as the bitmask, consuming 1-8 wrong bytes, which shifts all subsequent fields (spellId, castFlags, castTime) and causes: - Cast bar to never show for the player's own spells - Sound effects to use the wrong spell ID - Hit/miss target tracking to be completely wrong Additionally, TBC SMSG_SPELL_GO lacks the WotLK timestamp field after castFlags. Add TbcPacketParsers::parseSpellStart and ::parseSpellGo using full GUIDs, add virtual base methods, and route both handlers through virtual dispatch.
2026-03-09 21:48:41 -07:00
// TBC 2.4.3 SMSG_SPELL_START: full uint64 GUIDs (WotLK uses packed GUIDs)
bool parseSpellStart(network::Packet& packet, SpellStartData& data) override;
// TBC 2.4.3 SMSG_SPELL_GO: full uint64 GUIDs, no timestamp field (WotLK added one)
bool parseSpellGo(network::Packet& packet, SpellGoData& data) override;
tbc: fix SMSG_MAIL_LIST_RESULT parsing for TBC 2.4.3 TBC 2.4.3 differs from WotLK in four ways: - Header: uint8 count only (WotLK: uint32 totalCount + uint8 shownCount), so the WotLK parser was reading 4 garbage bytes before the count - No extra unknown uint32 between itemTextId and stationery in each entry - Attachment item GUID: full uint64 (WotLK uses uint32 low GUID) - Attachment enchants: 7 × uint32 id only (WotLK: 7 × {id+duration+charges}) The resulting mis-parse would scramble subject/money/cod/flags for every mail entry and corrupt all attachment reads. Add TbcPacketParsers::parseMailList with the correct TBC 2.4.3 format.
2026-03-09 21:30:45 -07:00
// TBC 2.4.3 SMSG_MAIL_LIST_RESULT: uint8 count (not uint32+uint8), no body field,
// attachment uses uint64 itemGuid (not uint32), enchants are 7×u32 id-only (not 7×{id+dur+charges})
bool parseMailList(network::Packet& packet, std::vector<MailMessage>& inbox) override;
tbc: fix combat damage parsing for TBC 2.4.3 TBC 2.4.3 SMSG_ATTACKERSTATEUPDATE and SMSG_SPELLNONMELEEDAMAGELOG send full uint64 GUIDs for attacker/target, while WotLK 3.3.5a uses packed (variable-length) GUIDs. Using the WotLK reader on TBC packets consumes 1-8 bytes where a fixed 8 are expected, shifting all subsequent reads and producing completely wrong damage/absorbed/resisted values. Add TbcPacketParsers overrides that read plain uint64 GUIDs. Also note that TBC SMSG_SPELLNONMELEEDAMAGELOG lacks the WotLK overkill field.
2026-03-09 21:34:02 -07:00
// TBC 2.4.3 SMSG_ATTACKERSTATEUPDATE uses full uint64 GUIDs (WotLK uses packed GUIDs)
bool parseAttackerStateUpdate(network::Packet& packet, AttackerStateUpdateData& data) override;
// TBC 2.4.3 SMSG_SPELLNONMELEEDAMAGELOG uses full uint64 GUIDs (WotLK uses packed GUIDs)
bool parseSpellDamageLog(network::Packet& packet, SpellDamageLogData& data) override;
tbc: fix heal log GUID parsing and route combat through virtual dispatch Add TbcPacketParsers::parseSpellHealLog override using full uint64 GUIDs (TBC) instead of packed GUIDs (WotLK). Route handleAttackerStateUpdate, handleSpellDamageLog, and handleSpellHealLog through the virtual packetParsers_ interface so expansion-specific overrides are actually called. Previously the game handler bypassed virtual dispatch with direct static parser calls, making all three TBC overrides dead code.
2026-03-09 21:36:12 -07:00
// TBC 2.4.3 SMSG_SPELLHEALLOG uses full uint64 GUIDs (WotLK uses packed GUIDs)
bool parseSpellHealLog(network::Packet& packet, SpellHealLogData& data) override;
tbc: fix quest log stride and CMSG_QUESTGIVER_QUERY_QUEST format TBC 2.4.3 quest log update fields use 4 fields per slot (questId, state, counts, timer) vs WotLK's 5 (extra counts field). The wrong stride (5) caused all quest log reads to use wrong indices beyond the first slot, breaking quest tracking on TBC servers. TBC 2.4.3 CMSG_QUESTGIVER_QUERY_QUEST is guid(8) + questId(4) = 12 bytes. WotLK added a trailing isDialogContinued(u8) byte that TBC servers don't expect; sending it caused quest details to not be sent back on some emulators.
2026-03-09 22:04:18 -07:00
// TBC 2.4.3 quest log has 4 update fields per slot (questId, state, counts, timer)
// WotLK expands this to 5 (splits counts into two fields).
uint8_t questLogStride() const override { return 4; }
// TBC 2.4.3 CMSG_QUESTGIVER_QUERY_QUEST: guid(8) + questId(4) — no trailing
// isDialogContinued byte that WotLK added
network::Packet buildQueryQuestPacket(uint64_t npcGuid, uint32_t questId) override;
game: fix TBC SMSG_QUESTGIVER_QUEST_DETAILS parsing by promoting Classic override to TbcPacketParsers TBC 2.4.3 and Classic 1.12 share the same SMSG_QUESTGIVER_QUEST_DETAILS format. WotLK 3.3.5a adds three extra fields (informUnit u64, flags u32, isFinished u8) that the base QuestDetailsParser::parse handles. TBC had no override, so it fell through to the WotLK heuristic which read flags+isFinished as if they were TBC fields, misaligning choiceCount, rewardMoney, and rewardXp. Fix: move parseQuestDetails from ClassicPacketParsers to TbcPacketParsers. Classic inherits it unchanged (formats are identical). Both expansions now correctly parse: no informUnit, activateAccept(u8), suggestedPlayers(u32), emote section, variable choice/reward item counts, rewardMoney, and rewardXp.
2026-03-10 04:37:03 -07:00
// TBC/Classic SMSG_QUESTGIVER_QUEST_DETAILS lacks informUnit(u64), flags(u32),
// isFinished(u8) that WotLK added; uses variable item counts + emote section.
bool parseQuestDetails(network::Packet& packet, QuestDetailsData& data) override;
Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
};
/**
* Classic 1.12.1 packet parsers.
*
* Inherits from TBC (shared: u8 UpdateFlags, has_transport byte).
*
* Differences from TBC:
* - No moveFlags2 byte (TBC has u8, Classic has none)
* - Only 6 speed fields (no flight speeds — flying added in TBC)
* - SPLINE_ENABLED at 0x00400000 (TBC/WotLK: 0x08000000)
* - Transport data has no timestamp (TBC adds u32 timestamp)
* - Pitch: only SWIMMING (no ONTRANSPORT secondary pitch)
* - CharEnum: no enchantment field per equipment slot
* - No SMSG_AURA_UPDATE (uses update fields, same as TBC)
*/
class ClassicPacketParsers : public TbcPacketParsers {
public:
Fix Turtle/Classic parsing and online player textures
2026-02-13 19:40:54 -08:00
uint8_t movementFlags2Size() const override { return 0; }
Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
bool parseCharEnum(network::Packet& packet, CharEnumResponse& response) override;
bool parseMovementBlock(network::Packet& packet, UpdateBlock& block) override;
void writeMovementPayload(network::Packet& packet, const MovementInfo& info) override;
network::Packet buildMovementPacket(LogicalOpcode opcode,
const MovementInfo& info,
uint64_t playerGuid = 0) override;
Fix vanilla spell casting and bag contents Vanilla CMSG_CAST_SPELL target mask is uint16 (not uint32 like WotLK), the extra 2 bytes were corrupting packets. Also implement full bag content tracking: extract container slot GUIDs from CONTAINER update objects, set proper bag sizes, and populate bag items in inventory rebuild.
2026-02-13 22:14:34 -08:00
network::Packet buildCastSpell(uint32_t spellId, uint64_t targetGuid, uint8_t castCount) override;
Fix item use (CMSG_USE_ITEM), mount tab, and inventory right-click - Fix SMSG_ITEM_QUERY_SINGLE_RESPONSE parsing: read statsCount stat pairs instead of always 10, use 2 damage entries (MAX_ITEM_PROTO_DAMAGES), and parse item spell data (spellId + spellTrigger per slot) - Pass item spell ID in CMSG_USE_ITEM packet so server processes item use requests (spellId=0 caused silent server rejection) - Add spellId parameter to buildUseItem interface across all expansions - Fix spellbook mount tab to use SkillLine 777 (Mounts) instead of 762 (Riding), so known mount summon spells appear correctly - Fix inventory right-click: use IsItemHovered+IsMouseClicked instead of IsItemClicked for InvisibleButton (which only tracks left-clicks) - Fix SlotKind enum declaration order in inventory_screen.hpp
2026-02-26 00:59:07 -08:00
network::Packet buildUseItem(uint8_t bagIndex, uint8_t slotIndex, uint64_t itemGuid, uint32_t spellId = 0) override;
Fix Classic/Turtle spell casting, cast fail parsing, and empty chat Three Classic packet format fixes: 1. CMSG_CAST_SPELL: target flags are uint32 (not uint16). The wrong size caused the server to misparse the packet as an item enchant operation, returning "item already enchanted". 2. SMSG_CAST_FAILED: Classic has no castCount byte prefix (added in TBC). Added parseCastFailed override to ClassicPacketParsers. Without this, the parser read the wrong bytes and produced "Spell cast failed (error 0)" for every failure. 3. SMSG_MESSAGECHAT: Removed spurious receiverGuid read for SAY/YELL types. Classic chat format has no second GUID before the message body — the extra 8-byte read consumed messageLen + message data, producing empty chat messages.
2026-02-14 16:54:43 -08:00
bool parseCastFailed(network::Packet& packet, CastFailedData& data) override;
fix: add Classic parseCastResult override with result enum +1 shift Classic 1.12 SMSG_CAST_RESULT uses an enum starting at 0=AFFECTING_COMBAT (no SUCCESS entry), while WotLK starts at 0=SUCCESS, 1=AFFECTING_COMBAT. Without this override, Classic result codes were handled by TBC's parseCastResult which passed them unshifted, causing result 0 (AFFECTING_COMBAT) to be silently treated as success with no error shown. This applies the same +1 shift used in parseCastFailed so all Classic spell failure codes map correctly to getSpellCastResultString.
2026-03-11 03:53:18 -07:00
bool parseCastResult(network::Packet& packet, uint32_t& spellId, uint8_t& result) override;
Vanilla/Turtle WoW compatibility: fix UPDATE_OBJECT, chat, equipment, creatures - Route SMSG_UPDATE_OBJECT through polymorphic parsers for correct vanilla format (uint8 updateFlags, 6 speeds vs WotLK uint16/9) - Fix SMSG_DESTROY_OBJECT for vanilla (8 bytes, no isDeath field) - Add MSG_MOVE_* handlers for other player movement relay - Add ClassicPacketParsers::parseMessageChat with targetGuid read and monster-type name handling - Resolve chat sender names from player name cache before display - Fix CSV DBC field 0 always treated as numeric ID (fixes 16+ garbled Turtle CSVs including Map, AreaTable, Spell, CreatureDisplayInfo) - Add CSV DBC validation: reject garbled CSVs (>80% zero IDs) and fall back to binary DBC files - Fix ItemDisplayInfo texture component field index (14+ not 15+) for binary DBC with gender-aware suffix resolution - Spawn other players as visible M2 models via creature callback - Map name cache dedup prevents overwrites from duplicate CSV records
2026-02-13 18:59:09 -08:00
bool parseMessageChat(network::Packet& packet, MessageChatData& data) override;
Add MCLQ water, TaxiPathNode transports, and vanilla M2 particles - Parse MCLQ sub-chunks in vanilla ADTs for water rendering (WotLK uses MH2O) - Load TaxiPathNode.dbc for MO_TRANSPORT world-coordinate paths (vanilla boats) - Parse data[] from SMSG_GAMEOBJECT_QUERY_RESPONSE (taxiPathId for transports) - Support vanilla M2 particle emitters (504-byte struct, different from WotLK 476) - Add character preview texture diagnostic logging - Fix disconnect handling on character screen (show error only when no chars)
2026-02-14 20:20:43 -08:00
bool parseGameObjectQueryResponse(network::Packet& packet, GameObjectQueryResponseData& data) override;
classic: fix SMSG_CREATURE_QUERY_RESPONSE — no iconName field in 1.12 Classic 1.12 SMSG_CREATURE_QUERY_RESPONSE has no iconName CString between subName and typeFlags. The TBC/WotLK parser was reading the typeFlags uint32 bytes as the iconName string, then reading the remaining bytes as typeFlags — producing garbage creature type/family/rank values and corrupting target frame display for all creatures on Classic servers. Add ClassicPacketParsers::parseCreatureQueryResponse without the iconName read, and route the game handler through virtual dispatch so the override is called.
2026-03-09 21:44:07 -07:00
// Classic 1.12 SMSG_CREATURE_QUERY_RESPONSE lacks the iconName string that TBC/WotLK include
bool parseCreatureQueryResponse(network::Packet& packet, CreatureQueryResponseData& data) override;
Fix gossip message parsing for Vanilla/Turtle (flight master hang) Classic gossip packets lack the menuId field and quest items don't have questFlags/isRepeatable, causing the WotLK parser to read garbage counts (541M quests) and hang. Added ClassicPacketParsers::parseGossipMessage override with the correct vanilla format.
2026-02-14 19:38:11 -08:00
bool parseGossipMessage(network::Packet& packet, GossipMessageData& data) override;
Fix vanilla M2 animations, movement packets, and DBC locale - Parse vanilla M2 animation tracks (flat arrays with M2Range indices) instead of skipping them, fixing T-pose on all vanilla models - Use C4Quaternion (float[4]) for vanilla bone rotations instead of CompressedQuat (int16[4]) which produced garbage transforms - Fix vanilla M2 attachment struct size (48 bytes, not 40) so weapons attach to correct bones instead of model origin - Route movement packets through expansion-specific packet parsers instead of hardcoded WotLK format, fixing server-side position sync - Fix Spell.dbc field indices for classic/turtle (Name=120, Rank=129, IconID=117) - were pointing to Portuguese locale column (+7 offset) - Change guild roster keybind from J to O (WoW default) - Add guild opcodes for all expansions
2026-02-13 21:39:48 -08:00
bool parseGuildRoster(network::Packet& packet, GuildRosterData& data) override;
bool parseGuildQueryResponse(network::Packet& packet, GuildQueryResponseData& data) override;
Add chat channels, chat settings, and fix missing chat text Fix WotLK chat parser not stripping null terminators from messages, fix channel message local echo missing channelName, expand default channels to General/Trade/LocalDefense/LookingForGroup with configurable auto-join, add Classic packet format for join/leave channel, display channel index prefix in chat, and add Chat settings tab with timestamps, font size, and auto-join toggles.
2026-02-14 18:27:59 -08:00
network::Packet buildJoinChannel(const std::string& channelName, const std::string& password) override;
network::Packet buildLeaveChannel(const std::string& channelName) override;
Implement mailbox interaction and expansion-aware mail system Fix mailbox right-click (transposed CMSG_GAMEOBJECT_USE opcode, missing mail opcodes in Turtle WoW JSON, decorative GO type filtering). Add expansion-aware mail packet handling via PacketParsers: Classic format (single item, no msgSize prefix, Vanilla field order) vs WotLK format (attachment arrays, enchant slots). Fix CMSG_MAIL_TAKE_ITEM and CMSG_MAIL_DELETE for Vanilla (no trailing fields). Add pulsing "New Mail" indicator below minimap, SMSG_RECEIVED_MAIL and MSG_QUERY_NEXT_MAIL_TIME handlers, and async sender name backfill.
2026-02-16 18:46:44 -08:00
network::Packet buildSendMail(uint64_t mailboxGuid, const std::string& recipient,
const std::string& subject, const std::string& body,
Add mail item attachment support for sending - CMSG_SEND_MAIL now includes item GUIDs (up to 12 per WotLK) - Right-click items in bags to attach when mail compose is open - Compose window shows 12-slot attachment grid with item icons - Click attached items to remove them - Classic/Vanilla falls back to single item GUID format
2026-02-25 14:11:09 -08:00
uint32_t money, uint32_t cod,
const std::vector<uint64_t>& itemGuids = {}) override;
Implement mailbox interaction and expansion-aware mail system Fix mailbox right-click (transposed CMSG_GAMEOBJECT_USE opcode, missing mail opcodes in Turtle WoW JSON, decorative GO type filtering). Add expansion-aware mail packet handling via PacketParsers: Classic format (single item, no msgSize prefix, Vanilla field order) vs WotLK format (attachment arrays, enchant slots). Fix CMSG_MAIL_TAKE_ITEM and CMSG_MAIL_DELETE for Vanilla (no trailing fields). Add pulsing "New Mail" indicator below minimap, SMSG_RECEIVED_MAIL and MSG_QUERY_NEXT_MAIL_TIME handlers, and async sender name backfill.
2026-02-16 18:46:44 -08:00
bool parseMailList(network::Packet& packet, std::vector<MailMessage>& inbox) override;
fix(mail): use attachment item guid for WotLK take item
2026-03-14 07:11:18 -07:00
network::Packet buildMailTakeItem(uint64_t mailboxGuid, uint32_t mailId, uint32_t itemGuidLow) override;
Implement mailbox interaction and expansion-aware mail system Fix mailbox right-click (transposed CMSG_GAMEOBJECT_USE opcode, missing mail opcodes in Turtle WoW JSON, decorative GO type filtering). Add expansion-aware mail packet handling via PacketParsers: Classic format (single item, no msgSize prefix, Vanilla field order) vs WotLK format (attachment arrays, enchant slots). Fix CMSG_MAIL_TAKE_ITEM and CMSG_MAIL_DELETE for Vanilla (no trailing fields). Add pulsing "New Mail" indicator below minimap, SMSG_RECEIVED_MAIL and MSG_QUERY_NEXT_MAIL_TIME handlers, and async sender name backfill.
2026-02-16 18:46:44 -08:00
network::Packet buildMailDelete(uint64_t mailboxGuid, uint32_t mailId, uint32_t mailTemplateId) override;
Fix Classic item query packet format for auction house item names Vanilla CMSG_ITEM_QUERY_SINGLE has no GUID field (just uint32 entry), causing servers to reject the oversized WotLK-format packets. Also fix response parser: remove nonexistent statsCount field and use 5 damage types instead of 2 to match Vanilla protocol.
2026-02-17 01:05:15 -08:00
network::Packet buildItemQuery(uint32_t entry, uint64_t guid) override;
Fix NPC textures, bag item interactions, and Classic item query parsing Rebuild creature display lookups after expansion-specific DBC layout loads (was using WotLK defaults before turtle layout was available). Add full drag-and-drop support for bag items with server-side CMSG_SWAP_ITEM packets. Add Classic-specific SMSG_ITEM_QUERY_SINGLE_RESPONSE parser for Vanilla format differences (fewer damage types, no scaling stats, no Flags2).
2026-02-17 01:00:04 -08:00
bool parseItemQueryResponse(network::Packet& packet, ItemQueryResponseData& data) override;
Fix Turtle WoW compatibility: NPC spawning, quests, spells, realm display, and music - Add TurtlePacketParsers with dedicated movement block parser (Classic format + transport timestamp) - Fix quest giver status: read uint32 and translate vanilla enum values for Classic/Turtle - Fix quest accept packet: remove trailing uint32 that vanilla servers reject - Fix quest details parser: auto-detect vanilla vs WotLK format (informUnit field) - Fix spellbook and action bar icons: fallback to WotLK DBC field indices when expansion layout fails - Fix spell cast failure messages: translate vanilla SpellCastResult codes (+1 offset) - Fix realm list: correct type values (6=RP, 8=RP-PvP) and population thresholds - Fix music: disable looping for zone music, auto-advance to next random track when finished - Add music anti-repeat: avoid playing the same track back-to-back - Make TBC update block parsing resilient (keep parsed blocks on failure instead of aborting) - Add right-click attack on hostile mobs - Add name query diagnostic logging
2026-02-17 05:27:03 -08:00
uint8_t readQuestGiverStatus(network::Packet& packet) override;
Fix quest system for Classic/Turtle: correct packet formats and log stride - CMSG_QUESTGIVER_QUERY_QUEST: Classic override omits trailing unk1 byte (WotLK sends 13 bytes, Classic servers expect 12 — extra byte caused server to silently drop the packet, preventing quest details dialog) - SMSG_QUESTGIVER_QUEST_DETAILS: Classic override skips informUnit GUID (WotLK prepends 8-byte informUnit before questId; Vanilla does not) - Quest log UPDATE_OBJECT stride: use packetParsers_->questLogStride() (WotLK=5 fields/slot, Classic=3 fields/slot) - handleQuestDetails: route through packetParsers_->parseQuestDetails() - selectGossipQuest: route through packetParsers_->buildQueryQuestPacket()
2026-02-18 04:56:23 -08:00
network::Packet buildQueryQuestPacket(uint64_t npcGuid, uint32_t questId) override;
Fix quest accept/abandon flow and expansion-specific accept packet format Normalize WoW quest text tokens during parsing so quest titles/details no longer leak raw markup like and |n into UI. Apply to WotLK and Classic parser paths, including quest list parsing in GameHandler. Harden quest state handling by mapping abandon requests to authoritative server quest-log slots (PLAYER_QUEST_LOG_START) instead of local vector order, with a guarded fallback when update fields are unavailable. Improve accept de-duplication by trusting server slot state over stale local cache; allow re-accept when local/server state diverges and trigger resync semantics. Add expansion-aware CMSG_QUESTGIVER_ACCEPT_QUEST builders: WotLK sends guid+questId+unk1(uint32), while TBC/Classic/Turtle send guid+questId only. Wire GameHandler through PacketParsers for compatibility across expansions and cores.
2026-02-20 23:20:02 -08:00
network::Packet buildAcceptQuestPacket(uint64_t npcGuid, uint32_t questId) override;
game: fix TBC SMSG_QUESTGIVER_QUEST_DETAILS parsing by promoting Classic override to TbcPacketParsers TBC 2.4.3 and Classic 1.12 share the same SMSG_QUESTGIVER_QUEST_DETAILS format. WotLK 3.3.5a adds three extra fields (informUnit u64, flags u32, isFinished u8) that the base QuestDetailsParser::parse handles. TBC had no override, so it fell through to the WotLK heuristic which read flags+isFinished as if they were TBC fields, misaligning choiceCount, rewardMoney, and rewardXp. Fix: move parseQuestDetails from ClassicPacketParsers to TbcPacketParsers. Classic inherits it unchanged (formats are identical). Both expansions now correctly parse: no informUnit, activateAccept(u8), suggestedPlayers(u32), emote section, variable choice/reward item counts, rewardMoney, and rewardXp.
2026-03-10 04:37:03 -07:00
// parseQuestDetails inherited from TbcPacketParsers (same format as TBC 2.4.3)
Fix quest system for Classic/Turtle: correct packet formats and log stride - CMSG_QUESTGIVER_QUERY_QUEST: Classic override omits trailing unk1 byte (WotLK sends 13 bytes, Classic servers expect 12 — extra byte caused server to silently drop the packet, preventing quest details dialog) - SMSG_QUESTGIVER_QUEST_DETAILS: Classic override skips informUnit GUID (WotLK prepends 8-byte informUnit before questId; Vanilla does not) - Quest log UPDATE_OBJECT stride: use packetParsers_->questLogStride() (WotLK=5 fields/slot, Classic=3 fields/slot) - handleQuestDetails: route through packetParsers_->parseQuestDetails() - selectGossipQuest: route through packetParsers_->buildQueryQuestPacket()
2026-02-18 04:56:23 -08:00
uint8_t questLogStride() const override { return 3; }
fix: use expansion-aware explored zone count to prevent fog-of-war corruption Classic 1.12 and Turtle WoW have only 64 PLAYER_EXPLORED_ZONES uint32 fields (zone IDs pack into 2048 bits). TBC and WotLK use 128 (needed for Outland/Northrend zone IDs up to bit 4095). The hardcoded PLAYER_EXPLORED_ZONES_COUNT=128 caused extractExploredZoneFields to read 64 extra fields beyond the actual zone block in Classic/Turtle — consuming PLAYER_REST_STATE_EXPERIENCE, PLAYER_FIELD_COINAGE, and character- points fields as zone flags. On the world map, this could mark zones as explored based on random bit patterns in those unrelated fields. Add `exploredZonesCount()` virtual method to PacketParsers (default=128, Classic/Turtle override=64) and use it in extractExploredZoneFields to limit reads to the correct block and zero-fill remaining slots.
2026-03-10 23:18:16 -07:00
// Classic 1.12 has 64 explored-zone uint32 fields (zone IDs fit in 2048 bits).
// TBC/WotLK use 128 (needed for Outland/Northrend zone IDs up to 4095).
uint8_t exploredZonesCount() const override { return 64; }
Fix classic SMSG_MONSTER_MOVE parsing using wrong WotLK format handleMonsterMove called MonsterMoveParser::parse() directly (WotLK format with extra uint8 after PackedGuid) instead of going through the polymorphic packetParsers_->parseMonsterMove(). Added parseVanilla override to ClassicPacketParsers so classic/turtle use the correct vanilla format.
2026-02-20 00:52:59 -08:00
bool parseMonsterMove(network::Packet& packet, MonsterMoveData& data) override {
return MonsterMoveParser::parseVanilla(packet, data);
}
fix: replace fragile heuristic in SMSG_INITIAL_SPELLS with explicit Classic format flag Classic 1.12 uses uint16 spellId + uint16 slot (4 bytes/spell); TBC and WotLK use uint32 spellId + uint16 unknown (6 bytes/spell). The old size-based heuristic could misdetect TBC packets that happened to fit both layouts. Add a vanillaFormat parameter to InitialSpellsParser::parse and override parseInitialSpells in ClassicPacketParsers to always pass true, eliminating the ambiguity.
2026-03-11 04:38:30 -07:00
// Classic 1.12 SMSG_INITIAL_SPELLS: uint16 spellId + uint16 slot per entry (not uint32 + uint16)
bool parseInitialSpells(network::Packet& packet, InitialSpellsData& data) override {
return InitialSpellsParser::parse(packet, data, /*vanillaFormat=*/true);
}
game: add Classic 1.12 overrides for parseSpellStart and parseSpellGo Vanilla 1.12 SMSG_SPELL_START and SMSG_SPELL_GO use: - PackedGuid (variable-length) for caster and target GUIDs, not full uint64 - uint16 castFlags, not uint32 as in TBC/WotLK - uint16 targetFlags in SpellCastTargets, not uint32 Without these overrides Classic inherited TBC's implementations which read 8 bytes for each GUID (over-reading the PackedGuid) and then 4 bytes for castFlags instead of 2, misaligning all subsequent fields and producing garbage spell IDs, cast times, and target GUIDs. Hit and miss target GUIDs in SMSG_SPELL_GO are also PackedGuid in Vanilla (vs full uint64 in TBC), handled by the new parseSpellGo.
2026-03-10 00:24:16 -07:00
// Classic 1.12 uses PackedGuid (not full uint64) and uint16 castFlags (not uint32)
bool parseSpellStart(network::Packet& packet, SpellStartData& data) override;
bool parseSpellGo(network::Packet& packet, SpellGoData& data) override;
game: add Classic 1.12 overrides for melee/spell damage log packets Vanilla 1.12 SMSG_ATTACKERSTATEUPDATE, SMSG_SPELLNONMELEEDAMAGELOG, and SMSG_SPELLHEALLOG use PackedGuid for all entity GUIDs, not full uint64 as TBC and WotLK do. Without these overrides Classic inherited TBC's implementations, which over-read PackedGuid fields as fixed 8-byte GUIDs, misaligning all subsequent damage/heal fields and making combat parsing unusable on Classic servers. The Classic override logic is identical to TBC except for the GUID reads, so combat text, damage numbers, and kill tracking now work correctly on Vanilla 1.12 connections.
2026-03-10 00:27:08 -07:00
// Classic 1.12 melee/spell log packets use PackedGuid (not full uint64)
bool parseAttackerStateUpdate(network::Packet& packet, AttackerStateUpdateData& data) override;
bool parseSpellDamageLog(network::Packet& packet, SpellDamageLogData& data) override;
bool parseSpellHealLog(network::Packet& packet, SpellHealLogData& data) override;
game: add Classic 1.12 parseAuraUpdate override to restore aura tracking Classic 1.12 sends SMSG_AURA_UPDATE/SMSG_AURA_UPDATE_ALL, but ClassicPacketParsers inherited TBC's override which returns false (TBC uses a different aura system and doesn't send SMSG_AURA_UPDATE at all). Classic aura format differs from WotLK in two key ways: - DURATION flag bit is 0x10 in Vanilla, not 0x20 as in WotLK; reading with the WotLK parser would incorrectly gate duration reads and misparse aura fields - No caster GUID field in Classic; WotLK parser tries to read one (gated by 0x08) which would consume spell ID or flag bytes from the next aura slot With this override, player/target aura bars and buff tracking work correctly on Classic 1.12 connections for the first time.
2026-03-10 00:30:28 -07:00
// Classic 1.12 has SMSG_AURA_UPDATE (unlike TBC which doesn't);
// format differs from WotLK: no caster GUID, DURATION flag is 0x10 not 0x20
bool parseAuraUpdate(network::Packet& packet, AuraUpdateData& data, bool isAll = false) override;
game: fix Classic 1.12 SMSG_NAME_QUERY_RESPONSE race/gender/class parsing Classic 1.12 servers (vmangos/cmangos-classic) send: uint64 guid + CString name + CString realmName + uint32 race + uint32 gender + uint32 class TBC's Variant A (which Classic inherited) skipped the realmName CString, causing the null terminator of the empty realmName to be absorbed into the low byte of the uint32 race read, producing race=0 and shifted gender/class. Adds a ClassicPacketParsers::parseNameQueryResponse override that correctly reads the realmName CString before the race/gender/class uint32 fields.
2026-03-10 00:53:03 -07:00
// Classic 1.12 SMSG_NAME_QUERY_RESPONSE: full uint64 guid + name + realmName CString +
// uint32 race + uint32 gender + uint32 class (TBC Variant A skips the realmName CString)
bool parseNameQueryResponse(network::Packet& packet, NameQueryResponseData& data) override;
Fix Turtle WoW compatibility: NPC spawning, quests, spells, realm display, and music - Add TurtlePacketParsers with dedicated movement block parser (Classic format + transport timestamp) - Fix quest giver status: read uint32 and translate vanilla enum values for Classic/Turtle - Fix quest accept packet: remove trailing uint32 that vanilla servers reject - Fix quest details parser: auto-detect vanilla vs WotLK format (informUnit field) - Fix spellbook and action bar icons: fallback to WotLK DBC field indices when expansion layout fails - Fix spell cast failure messages: translate vanilla SpellCastResult codes (+1 offset) - Fix realm list: correct type values (6=RP, 8=RP-PvP) and population thresholds - Fix music: disable looping for zone music, auto-advance to next random track when finished - Add music anti-repeat: avoid playing the same track back-to-back - Make TBC update block parsing resilient (keep parsed blocks on failure instead of aborting) - Add right-click attack on hostile mobs - Add name query diagnostic logging
2026-02-17 05:27:03 -08:00
};
/**
refactor: derive turtle opcodes from classic
2026-03-15 02:55:05 -07:00
* Turtle WoW packet parsers.
Fix Turtle WoW compatibility: NPC spawning, quests, spells, realm display, and music - Add TurtlePacketParsers with dedicated movement block parser (Classic format + transport timestamp) - Fix quest giver status: read uint32 and translate vanilla enum values for Classic/Turtle - Fix quest accept packet: remove trailing uint32 that vanilla servers reject - Fix quest details parser: auto-detect vanilla vs WotLK format (informUnit field) - Fix spellbook and action bar icons: fallback to WotLK DBC field indices when expansion layout fails - Fix spell cast failure messages: translate vanilla SpellCastResult codes (+1 offset) - Fix realm list: correct type values (6=RP, 8=RP-PvP) and population thresholds - Fix music: disable looping for zone music, auto-advance to next random track when finished - Add music anti-repeat: avoid playing the same track back-to-back - Make TBC update block parsing resilient (keep parsed blocks on failure instead of aborting) - Add right-click attack on hostile mobs - Add name query diagnostic logging
2026-02-17 05:27:03 -08:00
*
refactor: derive turtle opcodes from classic
2026-03-15 02:55:05 -07:00
* Turtle is Classic-based but not wire-identical to vanilla MaNGOS. It keeps
* most Classic packet formats, while overriding the movement-bearing paths that
* have proven to vary in live traffic:
* - update-object movement blocks use a Turtle-specific hybrid layout
* - update-object parsing falls back through Classic/TBC/WotLK movement layouts
* - monster-move parsing falls back through Vanilla, TBC, and guarded WotLK layouts
Fix Turtle WoW compatibility: NPC spawning, quests, spells, realm display, and music - Add TurtlePacketParsers with dedicated movement block parser (Classic format + transport timestamp) - Fix quest giver status: read uint32 and translate vanilla enum values for Classic/Turtle - Fix quest accept packet: remove trailing uint32 that vanilla servers reject - Fix quest details parser: auto-detect vanilla vs WotLK format (informUnit field) - Fix spellbook and action bar icons: fallback to WotLK DBC field indices when expansion layout fails - Fix spell cast failure messages: translate vanilla SpellCastResult codes (+1 offset) - Fix realm list: correct type values (6=RP, 8=RP-PvP) and population thresholds - Fix music: disable looping for zone music, auto-advance to next random track when finished - Add music anti-repeat: avoid playing the same track back-to-back - Make TBC update block parsing resilient (keep parsed blocks on failure instead of aborting) - Add right-click attack on hostile mobs - Add name query diagnostic logging
2026-02-17 05:27:03 -08:00
*
refactor: derive turtle opcodes from classic
2026-03-15 02:55:05 -07:00
* Everything else inherits the Classic parser behavior.
Fix Turtle WoW compatibility: NPC spawning, quests, spells, realm display, and music - Add TurtlePacketParsers with dedicated movement block parser (Classic format + transport timestamp) - Fix quest giver status: read uint32 and translate vanilla enum values for Classic/Turtle - Fix quest accept packet: remove trailing uint32 that vanilla servers reject - Fix quest details parser: auto-detect vanilla vs WotLK format (informUnit field) - Fix spellbook and action bar icons: fallback to WotLK DBC field indices when expansion layout fails - Fix spell cast failure messages: translate vanilla SpellCastResult codes (+1 offset) - Fix realm list: correct type values (6=RP, 8=RP-PvP) and population thresholds - Fix music: disable looping for zone music, auto-advance to next random track when finished - Add music anti-repeat: avoid playing the same track back-to-back - Make TBC update block parsing resilient (keep parsed blocks on failure instead of aborting) - Add right-click attack on hostile mobs - Add name query diagnostic logging
2026-02-17 05:27:03 -08:00
*/
class TurtlePacketParsers : public ClassicPacketParsers {
public:
uint8_t movementFlags2Size() const override { return 0; }
fix: stabilize turtle world entry session handling
2026-03-15 01:21:23 -07:00
bool parseUpdateObject(network::Packet& packet, UpdateObjectData& data) override;
Fix Turtle WoW compatibility: NPC spawning, quests, spells, realm display, and music - Add TurtlePacketParsers with dedicated movement block parser (Classic format + transport timestamp) - Fix quest giver status: read uint32 and translate vanilla enum values for Classic/Turtle - Fix quest accept packet: remove trailing uint32 that vanilla servers reject - Fix quest details parser: auto-detect vanilla vs WotLK format (informUnit field) - Fix spellbook and action bar icons: fallback to WotLK DBC field indices when expansion layout fails - Fix spell cast failure messages: translate vanilla SpellCastResult codes (+1 offset) - Fix realm list: correct type values (6=RP, 8=RP-PvP) and population thresholds - Fix music: disable looping for zone music, auto-advance to next random track when finished - Add music anti-repeat: avoid playing the same track back-to-back - Make TBC update block parsing resilient (keep parsed blocks on failure instead of aborting) - Add right-click attack on hostile mobs - Add name query diagnostic logging
2026-02-17 05:27:03 -08:00
bool parseMovementBlock(network::Packet& packet, UpdateBlock& block) override;
Stabilize streaming memory and parser handling; revert socket recv optimizations
2026-02-22 07:26:54 -08:00
bool parseMonsterMove(network::Packet& packet, MonsterMoveData& data) override;
Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
};
/**
* Factory function to create the right parser set for an expansion.
*/
inline std::unique_ptr<PacketParsers> createPacketParsers(const std::string& expansionId) {
Fix Turtle WoW compatibility: NPC spawning, quests, spells, realm display, and music - Add TurtlePacketParsers with dedicated movement block parser (Classic format + transport timestamp) - Fix quest giver status: read uint32 and translate vanilla enum values for Classic/Turtle - Fix quest accept packet: remove trailing uint32 that vanilla servers reject - Fix quest details parser: auto-detect vanilla vs WotLK format (informUnit field) - Fix spellbook and action bar icons: fallback to WotLK DBC field indices when expansion layout fails - Fix spell cast failure messages: translate vanilla SpellCastResult codes (+1 offset) - Fix realm list: correct type values (6=RP, 8=RP-PvP) and population thresholds - Fix music: disable looping for zone music, auto-advance to next random track when finished - Add music anti-repeat: avoid playing the same track back-to-back - Make TBC update block parsing resilient (keep parsed blocks on failure instead of aborting) - Add right-click attack on hostile mobs - Add name query diagnostic logging
2026-02-17 05:27:03 -08:00
if (expansionId == "classic") return std::make_unique<ClassicPacketParsers>();
if (expansionId == "turtle") return std::make_unique<TurtlePacketParsers>();
Add multi-expansion support with data-driven protocol layer Replace hardcoded WotLK protocol constants with a data-driven architecture supporting Classic 1.12.1, TBC 2.4.3, and WotLK 3.3.5a. Each expansion has JSON profiles for opcodes, update fields, and DBC layouts, plus C++ polymorphic packet parsers for binary format differences (movement flags, speed fields, transport data, spline format, char enum layout). Key components: - ExpansionRegistry: scans Data/expansions/*/expansion.json at startup - OpcodeTable: logical enum <-> wire values loaded from JSON - UpdateFieldTable: field indices loaded from JSON per expansion - DBCLayout: schema-driven DBC field lookups replacing magic numbers - PacketParsers: WotLK/TBC/Classic parsers with correct flag positions - Multi-manifest AssetManager: layered manifests with priority ordering - HDPackManager: overlay texture packs with expansion compatibility - Auth screen expansion picker replacing hardcoded version dropdown
2026-02-12 22:56:36 -08:00
if (expansionId == "tbc") return std::make_unique<TbcPacketParsers>();
return std::make_unique<WotlkPacketParsers>();
}
} // namespace game
} // namespace wowee
Reference in a new issue Copy permalink