phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-16 01:03:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(parsing): bail on suspicious maskBlockCount in CREATE_OBJECT blocks

Browse source 
When spline parsing consumes the wrong number of bytes, the subsequent
blockCount read lands on garbage data (e.g. 71 instead of ~5 for UNIT).
Previously the parser logged a warning but continued, reading garbage
mask/field data until hitting truncation. Now it returns false for
CREATE_OBJECT blocks with suspicious counts, letting the block loop
skip cleanly to the next entity.

Also downgrade ~44 diagnostic LOG_WARNING messages to LOG_DEBUG across
17 files (equipment, transport, DBC, heartbeat, chat, GO raypick, etc.)
to reduce log noise and make real warnings visible.
This commit is contained in:
Kelsi 2026-04-05 20:12:17 -07:00
parent e32f4fbff9
commit 069dd36698
18 changed files with 46 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/rendering/character_renderer.cpp
View file

@ -2368,7 +2368,7 @@ void CharacterRenderer::render(VkCommandBuffer cmd, VkDescriptorSet perFrameSet,
uint16_t bg = static_cast<uint16_t>(b.submeshId / 100);
bool active = instance.activeGeosets.empty() ||
instance.activeGeosets.count(b.submeshId);
LOG_WARNING("BATCH DIAG: submesh=", b.submeshId, " group=", bg,
LOG_DEBUG("BATCH DIAG: submesh=", b.submeshId, " group=", bg,
" blend=", bm, " matFlags=0x", std::hex, mf, std::dec,
" texIdx=", b.textureIndex, " matIdx=", b.materialIndex,
" active=", active);