phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-17 01:23:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(combatlog): parse packed spell-go hit target GUIDs

Browse source
This commit is contained in:
Kelsi 2026-03-13 21:08:00 -07:00
parent d4d876a563
commit 16c8a2fd33
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/game/world_packets.cpp
View file

@ -3660,12 +3660,13 @@ bool SpellGoParser::parse(network::Packet& packet, SpellGoData& data) {
data.hitTargets.reserve(data.hitCount); data.hitTargets.reserve(data.hitCount);
for (uint8_t i = 0; i < data.hitCount; ++i) { for (uint8_t i = 0; i < data.hitCount; ++i) {
if (packet.getSize() - packet.getReadPos() < 8) { // WotLK hit targets are packed GUIDs, like the caster and miss targets.
if (packet.getSize() - packet.getReadPos() < 1) {
LOG_WARNING("Spell go: truncated hit targets at index ", (int)i, "/", (int)data.hitCount); LOG_WARNING("Spell go: truncated hit targets at index ", (int)i, "/", (int)data.hitCount);
data.hitCount = i; data.hitCount = i;
break; break;
} }
data.hitTargets.push_back(packet.readUInt64()); data.hitTargets.push_back(UpdateObjectParser::readPackedGuid(packet));
} }
// Validate missCount field exists // Validate missCount field exists