phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-17 09:33:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: use uniform 22-byte loot item size for Classic/TBC/Turtle

Browse source 
SMSG_LOOT_RESPONSE items include randomSuffix and randomPropertyId
fields across all expansions, not just WotLK. Using 14-byte size for
Classic/TBC caused item data to be read at wrong offsets.
This commit is contained in:
Kelsi 2026-03-17 09:04:40 -07:00
parent 203514abc7
commit 3667ff4998
2 changed files with 16 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

5
include/game/world_packets.hpp
View file

@ -2060,8 +2060,9 @@ public:
/** SMSG_LOOT_RESPONSE parser */
class LootResponseParser {
public:
// isWotlkFormat: true for WotLK 3.3.5a (22 bytes/item with randomSuffix+randomProp),
// false for Classic 1.12 and TBC 2.4.3 (14 bytes/item).
// isWotlkFormat: true for WotLK (has trailing quest item section),
// false for Classic/TBC (no quest item section).
// Per-item size is 22 bytes across all expansions.
static bool parse(network::Packet& packet, LootResponseData& data, bool isWotlkFormat = true);
};