phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-23 07:40:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 26

Fix composite cache clearing to not delete NPC textures

Browse source 
clearCompositeCache() now only clears the lookup map without deleting
GPU textures, preventing NPC and other instance textures from being
accidentally destroyed during player equipment changes.
This commit is contained in:
Kelsi 2026-02-16 00:19:07 -08:00
parent dcd6c488fa
commit 4190cb796f
1 changed files with 3 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/rendering/character_renderer.cpp
View file

@ -576,22 +576,9 @@ GLuint CharacterRenderer::compositeTextures(const std::vector<std::string>& laye
}
void CharacterRenderer::clearCompositeCache() {
// Delete GPU textures that aren't referenced by any model's texture slots
for (auto& [key, texId] : compositeCache_) {
if (texId && texId != whiteTexture) {
// Check if any model still references this texture
bool inUse = false;
for (const auto& [mid, gm] : models) {
for (GLuint tid : gm.textureIds) {
if (tid == texId) { inUse = true; break; }
}
if (inUse) break;
}
if (!inUse) {
glDeleteTextures(1, &texId);
}
}
}
// Just clear the lookup map so next compositeWithRegions() creates fresh textures.
// Don't delete GPU textures — they may still be referenced by models or instances.
// Orphaned textures will be cleaned up when their model/instance is destroyed.
compositeCache_.clear();
}