phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: add missing TOGGLE_SKILLS to keybinding_manager (fixes CI build failure)

Browse source
This commit is contained in:
Kelsi 2026-03-17 21:08:02 -07:00
parent 5df5f4d423
commit 67c8101f67
2 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
include/ui/keybinding_manager.hpp
View file

@ -30,6 +30,7 @@ public:
TOGGLE_NAMEPLATES,
TOGGLE_RAID_FRAMES,
TOGGLE_ACHIEVEMENTS,
TOGGLE_SKILLS,
ACTION_COUNT
};

4
src/ui/keybinding_manager.cpp
View file

@ -36,6 +36,7 @@ void KeybindingManager::initializeDefaults() {
bindings_[static_cast<int>(Action::TOGGLE_NAMEPLATES)] = ImGuiKey_V;
bindings_[static_cast<int>(Action::TOGGLE_RAID_FRAMES)] = ImGuiKey_F; // Reassigned from R (now camera reset)
bindings_[static_cast<int>(Action::TOGGLE_ACHIEVEMENTS)] = ImGuiKey_Y; // WoW standard key (Shift+Y in retail)
bindings_[static_cast<int>(Action::TOGGLE_SKILLS)] = ImGuiKey_K; // WoW standard: K opens Skills/Professions
}
bool KeybindingManager::isActionPressed(Action action, bool repeat) {
@ -93,6 +94,7 @@ const char* KeybindingManager::getActionName(Action action) {
case Action::TOGGLE_NAMEPLATES: return "Nameplates";
case Action::TOGGLE_RAID_FRAMES: return "Raid Frames";
case Action::TOGGLE_ACHIEVEMENTS: return "Achievements";
case Action::TOGGLE_SKILLS: return "Skills / Professions";
case Action::ACTION_COUNT: break;
}
return "Unknown";
@ -158,6 +160,7 @@ void KeybindingManager::loadFromConfigFile(const std::string& filePath) {
else if (action == "toggle_raid_frames") actionIdx = static_cast<int>(Action::TOGGLE_RAID_FRAMES);
else if (action == "toggle_quest_log") actionIdx = static_cast<int>(Action::TOGGLE_QUESTS); // legacy alias
else if (action == "toggle_achievements") actionIdx = static_cast<int>(Action::TOGGLE_ACHIEVEMENTS);
else if (action == "toggle_skills") actionIdx = static_cast<int>(Action::TOGGLE_SKILLS);
if (actionIdx < 0) continue;
@ -254,6 +257,7 @@ void KeybindingManager::saveToConfigFile(const std::string& filePath) const {
{Action::TOGGLE_NAMEPLATES, "toggle_nameplates"},
{Action::TOGGLE_RAID_FRAMES, "toggle_raid_frames"},
{Action::TOGGLE_ACHIEVEMENTS, "toggle_achievements"},
{Action::TOGGLE_SKILLS, "toggle_skills"},
};
for (const auto& [action, nameStr] : actionMap) {