phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-06 17:13:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat(quest): detect orphan quests + speed up chain validation

Browse source 
validateChains now also flags quests with no questgiver and no
turn-in NPC — those are unreachable in-game and a common authoring
mistake. Also replaced the O(n²) inner lookup with an O(1)
unordered_map of id → nextId so circular detection scales.
This commit is contained in:
Kelsi 2026-05-06 07:33:31 -07:00
parent 778f4aca3e
commit 6b06bd07f9
1 changed files with 18 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

25
tools/editor/quest_editor.cpp
View file

@ -4,6 +4,7 @@
#include <fstream>
#include <filesystem>
#include <unordered_set>
#include <unordered_map>
namespace wowee {
namespace editor {
@ -156,7 +157,11 @@ bool QuestEditor::loadFromFile(const std::string& path) {
bool QuestEditor::validateChains(std::vector<std::string>& errors) const {
errors.clear();
std::unordered_set<uint32_t> validIds;
for (const auto& q : quests_) validIds.insert(q.id);
std::unordered_map<uint32_t, uint32_t> nextById; // id -> nextId
for (const auto& q : quests_) {
validIds.insert(q.id);
nextById[q.id] = q.nextQuestId;
}
for (const auto& q : quests_) {
if (q.nextQuestId != 0 && validIds.find(q.nextQuestId) == validIds.end()) {
@ -164,7 +169,16 @@ bool QuestEditor::validateChains(std::vector<std::string>& errors) const {
"\" chains to non-existent quest " + std::to_string(q.nextQuestId));
}
// Circular chain detection
// Quest with no questgiver and no turn-in is unreachable in-game.
// Common authoring mistake — flag it so the player isn't stuck
// wondering why a quest never appears.
if (q.questGiverNpcId == 0 && q.turnInNpcId == 0) {
errors.push_back("Quest [" + std::to_string(q.id) + "] \"" + q.title +
"\" has no questgiver or turn-in NPC (unreachable)");
}
// Circular chain detection. Use the precomputed map so the inner
// lookup is O(1) instead of O(n) — was O(n²) per starting quest.
if (q.nextQuestId != 0) {
std::unordered_set<uint32_t> visited;
uint32_t current = q.id;
@ -174,11 +188,8 @@ bool QuestEditor::validateChains(std::vector<std::string>& errors) const {
std::to_string(q.id) + "] \"" + q.title + "\"");
break;
}
uint32_t next = 0;
for (const auto& other : quests_) {
if (other.id == current) { next = other.nextQuestId; break; }
}
current = next;
auto it = nextById.find(current);
current = (it != nextById.end()) ? it->second : 0;
}
}
}