phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-03-22 23:30:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: resolve enchant names from SpellItemEnchantment.dbc in inspect window

Browse source
This commit is contained in:
Kelsi 2026-03-12 12:32:19 -07:00
parent 60794c6e0f
commit d48e4fb7c3
4 changed files with 42 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Data/expansions/tbc/dbc_layouts.json
View file

@ -97,5 +97,8 @@
"ID": 0, "MapID": 1, "AreaID": 2, "AreaName": 3, "ID": 0, "MapID": 1, "AreaID": 2, "AreaName": 3,
"LocLeft": 4, "LocRight": 5, "LocTop": 6, "LocBottom": 7, "LocLeft": 4, "LocRight": 5, "LocTop": 6, "LocBottom": 7,
"DisplayMapID": 8, "ParentWorldMapID": 10 "DisplayMapID": 8, "ParentWorldMapID": 10
},
"SpellItemEnchantment": {
"ID": 0, "Name": 8
} }
} }

3
Data/expansions/turtle/dbc_layouts.json
View file

@ -95,5 +95,8 @@
"ID": 0, "MapID": 1, "AreaID": 2, "AreaName": 3, "ID": 0, "MapID": 1, "AreaID": 2, "AreaName": 3,
"LocLeft": 4, "LocRight": 5, "LocTop": 6, "LocBottom": 7, "LocLeft": 4, "LocRight": 5, "LocTop": 6, "LocBottom": 7,
"DisplayMapID": 8, "ParentWorldMapID": 10 "DisplayMapID": 8, "ParentWorldMapID": 10
},
"SpellItemEnchantment": {
"ID": 0, "Name": 8
} }
} }

3
Data/expansions/wotlk/dbc_layouts.json
View file

@ -98,5 +98,8 @@
"ID": 0, "MapID": 1, "AreaID": 2, "AreaName": 3, "ID": 0, "MapID": 1, "AreaID": 2, "AreaName": 3,
"LocLeft": 4, "LocRight": 5, "LocTop": 6, "LocBottom": 7, "LocLeft": 4, "LocRight": 5, "LocTop": 6, "LocBottom": 7,
"DisplayMapID": 8, "ParentWorldMapID": 10 "DisplayMapID": 8, "ParentWorldMapID": 10
},
"SpellItemEnchantment": {
"ID": 0, "Name": 8
} }
} }

36
src/ui/game_screen.cpp
View file

@ -17996,6 +17996,28 @@ void GameScreen::renderObjectiveTracker(game::GameHandler& gameHandler) {
void GameScreen::renderInspectWindow(game::GameHandler& gameHandler) { void GameScreen::renderInspectWindow(game::GameHandler& gameHandler) {
if (!showInspectWindow_) return; if (!showInspectWindow_) return;
// Lazy-load SpellItemEnchantment.dbc for enchant name lookup
static std::unordered_map<uint32_t, std::string> s_enchantNames;
static bool s_enchantDbLoaded = false;
auto* assetMgrEnchant = core::Application::getInstance().getAssetManager();
if (!s_enchantDbLoaded && assetMgrEnchant && assetMgrEnchant->isInitialized()) {
s_enchantDbLoaded = true;
auto dbc = assetMgrEnchant->loadDBC("SpellItemEnchantment.dbc");
if (dbc && dbc->isLoaded()) {
const auto* layout = pipeline::getActiveDBCLayout()
? pipeline::getActiveDBCLayout()->getLayout("SpellItemEnchantment")
: nullptr;
uint32_t idField = layout ? (*layout)["ID"] : 0;
uint32_t nameField = layout ? (*layout)["Name"] : 8;
for (uint32_t i = 0; i < dbc->getRecordCount(); ++i) {
uint32_t id = dbc->getUInt32(i, idField);
if (id == 0) continue;
std::string nm = dbc->getString(i, nameField);
if (!nm.empty()) s_enchantNames[id] = std::move(nm);
}
}
}
// Slot index 0..18 maps to equipment slots 1..19 (WoW convention: slot 0 unused on server) // Slot index 0..18 maps to equipment slots 1..19 (WoW convention: slot 0 unused on server)
static const char* kSlotNames[19] = { static const char* kSlotNames[19] = {
"Head", "Neck", "Shoulder", "Shirt", "Chest", "Head", "Neck", "Shoulder", "Shirt", "Chest",
@ -18122,10 +18144,18 @@ void GameScreen::renderInspectWindow(game::GameHandler& gameHandler) {
ImGui::TextColored(qColor, "%s", info->name.c_str()); ImGui::TextColored(qColor, "%s", info->name.c_str());
// Enchant indicator on the same row as the name // Enchant indicator on the same row as the name
if (enchantId != 0) { if (enchantId != 0) {
auto enchIt = s_enchantNames.find(enchantId);
const std::string& enchName = (enchIt != s_enchantNames.end())
? enchIt->second : std::string{};
ImGui::SameLine(); ImGui::SameLine();
ImGui::TextColored(ImVec4(0.6f, 0.85f, 1.0f, 1.0f), "\xe2\x9c\xa6"); // UTF-8 ✦ if (!enchName.empty()) {
if (ImGui::IsItemHovered()) ImGui::TextColored(ImVec4(0.6f, 0.85f, 1.0f, 1.0f),
ImGui::SetTooltip("Enchanted (ID %u)", static_cast<unsigned>(enchantId)); "\xe2\x9c\xa6 %s", enchName.c_str()); // UTF-8 ✦
} else {
ImGui::TextColored(ImVec4(0.6f, 0.85f, 1.0f, 1.0f), "\xe2\x9c\xa6");
if (ImGui::IsItemHovered())
ImGui::SetTooltip("Enchanted (ID %u)", static_cast<unsigned>(enchantId));
}
} }
ImGui::EndGroup(); ImGui::EndGroup();
hovered = hovered || ImGui::IsItemHovered(); hovered = hovered || ImGui::IsItemHovered();