phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-04-17 01:23:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: misleading indentation on reputation addon event dispatch

Browse source 
The two fireAddonEvent calls were indented as if conditional on
repChangeCallback_ but actually execute unconditionally (no braces).
Fixed indentation and added clarifying comment.
This commit is contained in:
Kelsi 2026-03-29 21:35:49 -07:00
parent bbb560f93c
commit e42f8f1c03
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/game/social_handler.cpp
View file

@ -2479,8 +2479,9 @@ void SocialHandler::handleSetFactionStanding(network::Packet& packet) {
owner_.addSystemChatMessage(buf);
owner_.watchedFactionId_ = factionId;
if (owner_.repChangeCallback_) owner_.repChangeCallback_(name, delta, standing);
owner_.fireAddonEvent("UPDATE_FACTION", {});
owner_.fireAddonEvent("CHAT_MSG_COMBAT_FACTION_CHANGE", {std::string(buf)});
// These events fire unconditionally on any rep change (not gated by callback).
owner_.fireAddonEvent("UPDATE_FACTION", {});
owner_.fireAddonEvent("CHAT_MSG_COMBAT_FACTION_CHANGE", {std::string(buf)});
}
}
}