phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-03 08:03:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

game: downgrade false-positive LOG_WARNING calls for normal game events

Browse source 
SMSG_SHOW_BANK and SMSG_BUY_BANK_SLOT_RESULT are normal interactions
that were incorrectly logged at WARNING level. LOGIN_VERIFY_WORLD coord
dump is diagnostic detail, not a warning condition. Downgraded:
- SMSG_SHOW_BANK: LOG_WARNING → LOG_INFO
- SMSG_BUY_BANK_SLOT_RESULT: LOG_WARNING → LOG_INFO
- SMSG_TRANSFER_PENDING: LOG_WARNING → LOG_INFO (from previous session)
- SMSG_NEW_WORLD: LOG_WARNING → LOG_INFO (from previous session)
- LOGIN_VERIFY_WORLD coord dump: LOG_WARNING → LOG_DEBUG
This commit is contained in:
Kelsi 2026-03-10 04:56:42 -07:00
parent 4dab5daf79
commit f0233c092b
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
src/game/game_handler.cpp
View file

@ -4147,7 +4147,7 @@ void GameHandler::handlePacket(network::Packet& packet) {
case Opcode::SMSG_TRANSFER_PENDING: { case Opcode::SMSG_TRANSFER_PENDING: {
// SMSG_TRANSFER_PENDING: uint32 mapId, then optional transport data // SMSG_TRANSFER_PENDING: uint32 mapId, then optional transport data
uint32_t pendingMapId = packet.readUInt32(); uint32_t pendingMapId = packet.readUInt32();
LOG_WARNING("SMSG_TRANSFER_PENDING: mapId=", pendingMapId); LOG_INFO("SMSG_TRANSFER_PENDING: mapId=", pendingMapId);
// Optional: if remaining data, there's a transport entry + mapId // Optional: if remaining data, there's a transport entry + mapId
if (packet.getReadPos() + 8 <= packet.getSize()) { if (packet.getReadPos() + 8 <= packet.getSize()) {
uint32_t transportEntry = packet.readUInt32(); uint32_t transportEntry = packet.readUInt32();
@ -5959,7 +5959,7 @@ void GameHandler::handleLoginVerifyWorld(network::Packet& packet) {
// Initialize movement info with world entry position (server → canonical) // Initialize movement info with world entry position (server → canonical)
glm::vec3 canonical = core::coords::serverToCanonical(glm::vec3(data.x, data.y, data.z)); glm::vec3 canonical = core::coords::serverToCanonical(glm::vec3(data.x, data.y, data.z));
LOG_WARNING("LOGIN_VERIFY_WORLD: server=(", data.x, ", ", data.y, ", ", data.z, LOG_DEBUG("LOGIN_VERIFY_WORLD: server=(", data.x, ", ", data.y, ", ", data.z,
") canonical=(", canonical.x, ", ", canonical.y, ", ", canonical.z, ") mapId=", data.mapId); ") canonical=(", canonical.x, ", ", canonical.y, ", ", canonical.z, ") mapId=", data.mapId);
movementInfo.x = canonical.x; movementInfo.x = canonical.x;
movementInfo.y = canonical.y; movementInfo.y = canonical.y;
@ -15495,7 +15495,7 @@ void GameHandler::handleNewWorld(network::Packet& packet) {
float serverZ = packet.readFloat(); float serverZ = packet.readFloat();
float orientation = packet.readFloat(); float orientation = packet.readFloat();
LOG_WARNING("SMSG_NEW_WORLD: mapId=", mapId, LOG_INFO("SMSG_NEW_WORLD: mapId=", mapId,
" pos=(", serverX, ", ", serverY, ", ", serverZ, ")", " pos=(", serverX, ", ", serverY, ", ", serverZ, ")",
" orient=", orientation); " orient=", orientation);
@ -17361,7 +17361,7 @@ void GameHandler::handleShowBank(network::Packet& packet) {
for (int i = 0; i < effectiveBankBagSlots_; i++) { for (int i = 0; i < effectiveBankBagSlots_; i++) {
if (inventory.getBankBagSize(i) > 0) filledBags++; if (inventory.getBankBagSize(i) > 0) filledBags++;
} }
LOG_WARNING("SMSG_SHOW_BANK: banker=0x", std::hex, bankerGuid_, std::dec, LOG_INFO("SMSG_SHOW_BANK: banker=0x", std::hex, bankerGuid_, std::dec,
" purchased=", static_cast<int>(inventory.getPurchasedBankBagSlots()), " purchased=", static_cast<int>(inventory.getPurchasedBankBagSlots()),
" filledBags=", filledBags, " filledBags=", filledBags,
" effectiveBankBagSlots=", effectiveBankBagSlots_); " effectiveBankBagSlots=", effectiveBankBagSlots_);
@ -17370,7 +17370,7 @@ void GameHandler::handleShowBank(network::Packet& packet) {
void GameHandler::handleBuyBankSlotResult(network::Packet& packet) { void GameHandler::handleBuyBankSlotResult(network::Packet& packet) {
if (packet.getSize() - packet.getReadPos() < 4) return; if (packet.getSize() - packet.getReadPos() < 4) return;
uint32_t result = packet.readUInt32(); uint32_t result = packet.readUInt32();
LOG_WARNING("SMSG_BUY_BANK_SLOT_RESULT: result=", result); LOG_INFO("SMSG_BUY_BANK_SLOT_RESULT: result=", result);
// AzerothCore/TrinityCore: 0=TOO_MANY, 1=INSUFFICIENT_FUNDS, 2=NOT_BANKER, 3=OK // AzerothCore/TrinityCore: 0=TOO_MANY, 1=INSUFFICIENT_FUNDS, 2=NOT_BANKER, 3=OK
if (result == 3) { if (result == 3) {
addSystemChatMessage("Bank slot purchased."); addSystemChatMessage("Bank slot purchased.");