phaneron/Kelsidavis-WoWee
1
0
Fork 0
mirror of https://github.com/Kelsidavis/WoWee.git synced 2026-05-05 00:33:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(vulkan): re-allocate megaBoneSet_ after descriptor pool reset and fix PlayerFrame ImGui crash
Some checks failed
Build / Build (arm64) (push) Has been cancelled
Details
Build / Build (x86-64) (push) Has been cancelled
Details
Build / Build (macOS arm64) (push) Has been cancelled
Details
Build / Build (windows-arm64) (push) Has been cancelled
Details
Build / Build (windows-x86-64) (push) Has been cancelled
Details
Security / CodeQL (C/C++) (push) Has been cancelled
Details
Security / Semgrep (push) Has been cancelled
Details
Security / Sanitizer Build (ASan/UBSan) (push) Has been cancelled
Details

Browse source 
Re-allocate megaBoneSet_[0..1] in M2Renderer::clear() after vkResetDescriptorPool invalidates all
sets from boneDescPool_. Stale handles were bound to command buffers during rendering, causing
cascading validation errors. Also add ImGui::Dummy() after SetCursorScreenPos in the shaman totem
bar to satisfy ImGui's window boundary extension assertion.
This commit is contained in:
Kelsi 2026-04-15 13:22:30 -07:00
parent 01fecbf3e0
commit f9f02569d6
2 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/rendering/m2_renderer_instance.cpp
View file

@ -330,6 +330,23 @@ void M2Renderer::clear() {
write.pBufferInfo = &bufInfo;
vkUpdateDescriptorSets(device, 1, &write, 0, nullptr);
}
// Re-allocate mega bone sets (invalidated by pool reset)
for (int i = 0; i < 2; i++) {
megaBoneSet_[i] = allocateBoneSet();
if (megaBoneSet_[i] && megaBoneBuffer_[i]) {
VkDescriptorBufferInfo mbInfo{};
mbInfo.buffer = megaBoneBuffer_[i];
mbInfo.offset = 0;
mbInfo.range = MEGA_BONE_MAX_INSTANCES * MAX_BONES_PER_INSTANCE * sizeof(glm::mat4);
VkWriteDescriptorSet mw{VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET};
mw.dstSet = megaBoneSet_[i];
mw.dstBinding = 0;
mw.descriptorCount = 1;
mw.descriptorType = VK_DESCRIPTOR_TYPE_STORAGE_BUFFER;
mw.pBufferInfo = &mbInfo;
vkUpdateDescriptorSets(device, 1, &mw, 0, nullptr);
}
}
}
}
models.clear();