mirror of
https://github.com/Kelsidavis/WoWee.git
synced 2026-04-27 05:23:51 +00:00
97106bd6ae
Magic number elimination: - Create protocol_constants.hpp, warden_constants.hpp, render_constants.hpp, ui_constants.hpp - Replace ~55 magic numbers across game_handler, warden_handler, m2_renderer_render Reduce nesting depth: - Extract 5 parseEffect* methods from handleSpellLogExecute (max indent 52 → 16 cols) - Extract resolveSpellSchool/playSpellCastSound/playSpellImpactSound from 3× duplicate audio blocks in handleSpellGo - Flatten SMSG_INVENTORY_CHANGE_FAILURE with early-return guards - Extract drawScreenEdgeVignette() for 3 duplicate vignette blocks DRY extract patterns: - Replace 12 compound expansion checks with isPreWotlk() across movement_handler (9), chat_handler (1), social_handler (1) const to constexpr: - Promote 23+ static const arrays/scalars to static constexpr across 12 source files Error handling: - Convert PIN auth from exceptions to std::optional<PinProof> - Add [[nodiscard]] to 15+ initialize/parse methods - Wrap ~20 unchecked initialize() calls with LOG_WARNING/LOG_ERROR Signed-off-by: Pavel Okhlopkov <pavel.okhlopkov@flant.com> |
||
|---|---|---|
| .. | ||
| character.cpp | ||
| chat_handler.cpp | ||
| combat_handler.cpp | ||
| entity.cpp | ||
| entity_controller.cpp | ||
| expansion_profile.cpp | ||
| game_handler.cpp | ||
| game_handler_callbacks.cpp | ||
| game_handler_packets.cpp | ||
| inventory.cpp | ||
| inventory_handler.cpp | ||
| movement_handler.cpp | ||
| opcode_table.cpp | ||
| opcodes.cpp | ||
| packet_parsers_classic.cpp | ||
| packet_parsers_tbc.cpp | ||
| player.cpp | ||
| quest_handler.cpp | ||
| social_handler.cpp | ||
| spell_handler.cpp | ||
| transport_manager.cpp | ||
| update_field_table.cpp | ||
| warden_crypto.cpp | ||
| warden_emulator.cpp | ||
| warden_handler.cpp | ||
| warden_memory.cpp | ||
| warden_module.cpp | ||
| world.cpp | ||
| world_packets.cpp | ||
| world_packets_economy.cpp | ||
| world_packets_entity.cpp | ||
| world_packets_social.cpp | ||
| world_packets_world.cpp | ||
| zone_manager.cpp | ||